Conversation
…except me found and fixed this....
Member
|
Jip. We should probably get that in. I suggest we get a unit-test added for this as well. A simple test that the original issue (NASAWorldWind#155) mentions is to test whether the determinant of a square Matrix is equal to the determinant of its transpose. We can probably add a test that looks something like this: |
Added a unit-test that checks if the determinant of a Matrix is equal to the determinant of its transpose. This test will break without the determinant-fix.
Member
|
We should probably check if this bug is not present in the other versions of WorldWind as well, most notably worldwindjs. |
Changed the determinant test to check that the condition hold for any random matrix (and not jus the sample matrix used initially).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…except me found and fixed this....
fixes this one:
NASAWorldWind#155