issue #340: add test to validate non useless validation rule on maxOccurs="unbounded"

Author: mikaelcom

.php-cs-fixer.php

@@ -12,5 +12,6 @@
         'phpdoc_separation' => false,
         'single_line_empty_body' => false,
         'phpdoc_align' => false,
+        'php_unit_test_class_requires_covers' => false,
     ))
     ->setFinder($finder);

src/File/Validation/ChoiceRule.php

@@ -7,6 +7,7 @@
 use WsdlToPhp\PackageGenerator\File\AbstractModelFile;
 use WsdlToPhp\PackageGenerator\File\Element\PhpFunctionParameter;
 use WsdlToPhp\PackageGenerator\Model\StructAttribute;
+use WsdlToPhp\PhpGenerator\Element\AssignedValueElementInterface;
 use WsdlToPhp\PhpGenerator\Element\PhpMethod;
 
 final class ChoiceRule extends AbstractRule
@@ -51,7 +52,7 @@ protected function addValidationMethod(string $parameterName, array $choiceNames
         }
 
         $method = new PhpMethod($this->getValidationMethodName($parameterName), [
-            new PhpFunctionParameter('value', PhpFunctionParameter::NO_VALUE),
+            new PhpFunctionParameter('value', AssignedValueElementInterface::NO_VALUE),
         ], AbstractModelFile::TYPE_STRING);
 
         $method

src/Parser/Wsdl/TagChoice.php

@@ -7,9 +7,9 @@
 use WsdlToPhp\PackageGenerator\Model\Struct;
 use WsdlToPhp\PackageGenerator\Model\StructAttribute;
 use WsdlToPhp\PackageGenerator\Model\Wsdl;
+use WsdlToPhp\WsdlHandler\AbstractDocument;
 use WsdlToPhp\WsdlHandler\Tag\AbstractTag;
 use WsdlToPhp\WsdlHandler\Tag\TagChoice as Choice;
-use WsdlToPhp\WsdlHandler\Wsdl as WsdlDocument;
 
 final class TagChoice extends AbstractTagParser
 {
@@ -42,7 +42,7 @@ protected function parseWsdl(Wsdl $wsdl): void
 
     protected function parsingTag(): string
     {
-        return WsdlDocument::TAG_CHOICE;
+        return AbstractDocument::TAG_CHOICE;
     }
 
     protected function parseChoiceChild(Choice $choice, array $choiceNames, AbstractTag $child, Struct $struct): void

tests/Command/GeneratePackageCommandTest.php

@@ -14,7 +14,6 @@
 
 /**
  * @internal
- * @coversDefaultClass
  */
 final class GeneratePackageCommandTest extends AbstractTestCase
 {

tests/ConfigurationReader/GeneratorOptionsTest.php

@@ -13,7 +13,6 @@
 
 /**
  * @internal
- * @coversDefaultClass
  */
 final class GeneratorOptionsTest extends AbstractTestCase
 {

tests/ConfigurationReader/PhpReservedKeywordTest.php

@@ -9,7 +9,6 @@
 
 /**
  * @internal
- * @coversDefaultClass
  */
 final class PhpReservedKeywordTest extends AbstractTestCase
 {

tests/ConfigurationReader/ServiceReservedMethodTest.php

@@ -9,7 +9,6 @@
 
 /**
  * @internal
- * @coversDefaultClass
  */
 final class ServiceReservedMethodTest extends AbstractTestCase
 {

tests/ConfigurationReader/StructArrayReservedMethodTest.php

@@ -9,7 +9,6 @@
 
 /**
  * @internal
- * @coversDefaultClass
  */
 final class StructArrayReservedMethodTest extends AbstractTestCase
 {

tests/ConfigurationReader/StructReservedMethodTest.php

@@ -9,7 +9,6 @@
 
 /**
  * @internal
- * @coversDefaultClass
  */
 final class StructReservedMethodTest extends AbstractTestCase
 {

tests/ConfigurationReader/XsdTypesTest.php

@@ -9,7 +9,6 @@
 
 /**
  * @internal
- * @coversDefaultClass
  */
 final class XsdTypesTest extends AbstractTestCase
 {