fix issue #341: update generated files based on new DomHandler release#343
Conversation
7b74cae to
9d09395
Compare
mikaelcom
changed the title
9d09395 to
d5ccb55
Compare
Coverage Report
|
|
| $generator->parse(); | ||
|
|
||
| // uncomment the next line to easily regenerate file :) | ||
| // file_put_contents(sprintf('%sjson_serialized.json', self::getTestDirectory()), trim(json_encode($generator, JSON_PRETTY_PRINT))); |
There was a problem hiding this comment.
just wondering but what is the difference to using the generate_serialized_jsons file specified in the Makefile?
There was a problem hiding this comment.
These files are used for the tests and it avoids loading the WSDL + the schema each time needs to test a scenario against an element from the WSDL. The JSONs are the results of the parsed WSDL + Schemas and are loaded "instantly", it's just for performance during the tests
There was a problem hiding this comment.
I read again your question I answered too fast! What you say is that the test could rely on one of the updated json files? I did not think of that before 😉 (if that's actually your question)
There was a problem hiding this comment.
Ah. No, my fault for not articulating the question well.
I was actually just wondering regarding the commented out line. It says above that it can be used to regenerate the serialized.json file(s).
However, in the makefile there is a new json entry that is used to call generate_serialized_jsons.php which I guess regenerates all json files?
Just wondering, if one of those would not be enough actually?
However, I guess the commented out line could be helpful if one only runs individual tests?
AndreasA
left a comment
AndreasA
left a comment
There was a problem hiding this comment.
due to the amount of lines changed and as it is basically always the same chage (and it is tricky to keep exact track of progress - espeically the large files):
for the generated files (json and php) I only did spot checks or fast scroll through the files that they only change the corresponding removable check/necessary changes regarding removable.
|
@mikaelcom Btw. thanks for the invitation to the organization but I don't think it currenlty makes sense as I currently do not have the necessary time to invest in such projects on a more time intensive scale - so I will have to decline (at least for now). |
Hello, there's no comitment attached/awaited to the organization and more precisely to the group I intend to invite you in, its only purpose is to allow to you validate the PRs. Would you simply agree to that or not at all? |
|
is it for the purpose of approving this PR for merge? I guess I can join the organization then for that purpose. I can always leave it again - only currently needing to access some SOAP APIs again which is why I noticed such issues again 😄 |
Yes :) |
2 participants
No description provided.