Skip to content

Commit f88c03f

Browse files
author
Test
committed
modificados: docs/changelog.md (quitar IDs internos)
modificados: tests/System/Release/ScriptJobDisplayNameReleaseTest.php (serial vs paralelo)
1 parent ce295c3 commit f88c03f

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

tests/System/Release/ScriptJobDisplayNameReleaseTest.php

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,15 @@ public function job_output_shows_job_name_not_executable_path_for_script_type():
5656
}
5757

5858
/**
59-
* The real-world case from the bug report: two parallel script jobs with the
60-
* same executable. Before the fix they were indistinguishable in the output;
61-
* after the fix each one reports its own job key.
59+
* The real-world case from the bug report: two script jobs sharing the same
60+
* executable. Before the fix they were indistinguishable in the output;
61+
* after the fix each one reports its own job key. Runs the default sequential
62+
* executor — the bug lives in JobExecutor's display logic, identical under
63+
* both serial and parallel scheduling, so a single mode is enough.
6264
*
6365
* @test
6466
*/
65-
public function two_parallel_script_jobs_with_same_executable_are_distinguishable(): void
67+
public function two_script_jobs_with_same_executable_are_distinguishable(): void
6668
{
6769
$this->configurationFileBuilder
6870
->setV3Flows(['shards' => ['jobs' => ['shard_a', 'shard_b']]])
@@ -79,7 +81,7 @@ public function two_parallel_script_jobs_with_same_executable_are_distinguishabl
7981

8082
file_put_contents($this->configPath, $this->configurationFileBuilder->buildV3Php());
8183

82-
passthru("$this->githooks flow shards --config=$this->configPath --processes=2 2>&1", $exitCode);
84+
passthru("$this->githooks flow shards --config=$this->configPath 2>&1", $exitCode);
8385

8486
$this->assertEquals(0, $exitCode);
8587
$output = $this->getActualOutput();
@@ -89,7 +91,7 @@ public function two_parallel_script_jobs_with_same_executable_are_distinguishabl
8991
$this->assertLessThanOrEqual(
9092
1,
9193
substr_count($output, '/bin/echo identical-runner - OK'),
92-
'Two parallel script jobs were shown with their executable instead of their job key.'
94+
'Two script jobs were shown with their executable instead of their job key.'
9395
);
9496
}
9597
}

0 commit comments

Comments
 (0)