Recursive mode?

[gardar]

First of all I wanted to thank you for making this, I've been a long time user of cfv and I'm a bit amazed how significant the speed improvements are, even on a old server that has a high cpu load and sata disks.

With that being said, there are two minor features that I miss from cfv, one of them being recursive mode cfv -r which will check sfv files from all sub-directories and the other one is being able to run the application without specifying the sfv file to check.
I know it would be fairly simple to create a shell script wrapper or even a zsh/bash alias for it, but still it would be nice if it was built-in (assuming that it wouldn't be a huge performance hit).

[Wunkolo]

I can look into it!

[gardar]

Any luck? :)

[Wunkolo]

Sorry for sleeping on this 😅
Checking recursive sfv files should be pretty easy to implement since it can just read recursive .sfv files and add each entry to a big list of jobs.

For creation though, based on how cfv implements this:
https://github.com/cfv-project/cfv/blob/4f9473336ceea280a7f540a61a64327dde81882b/cfv.1#L27-L31
it might take a bit of a re-architecting to get it to write separate checksum files for each directory. Currently qCheck is setup to just take in a list of files to generate one central sfv in stdout but it should be possible.

I'll probably create separate PRs for checking sfv files recursively and another for creating checksum files for each recursive folder to simulate cfv's -r functionality!

Again, sorry for taking so long!

[Wunkolo]

Made some changes to try and implement this with the smallest amount of generic features as possible. Specifically, I implemented an -r/--recursive argument now that allows you to specify the recursion depth. This is only implemented for checking files at the moment, not recursively-creating .sfv files.

recursive mode cfv -r which will check sfv files from all sub-directories

This is possible now with qCheck -c -r {./foo/bar/folder} {foo.sfv}(recursively check sfv files within the input arguments that are paths)!

being able to run the application without specifying the sfv file to check

This is possible now with qCheck -c -r1 .(recursively check all .sfv in the current directory with a recursive-depth of 1)

Lemme know how it goes!

[gardar]

Sorry for the radio silence, I've been using the recursive mode now ever since you added it and it's working great for me... I even caught myself using qCheck -c -r where there's no recursion as it auto picks up the sfv that's in the directory, so the implementation of the recursive mode actually checks both boxes, being able to recursively check directories and not having to define the sfv to check.

The only minor improvement that I could suggest would be to make the status output a bit clearer after each directory has been checked as now it's all just printed as one long list which can makes it visually a bit tough to read. Maybe some sort of a summary at the end of the sfv check would be good, it would benefit both the recursive mode and individual file checks... Perhaps something like:

file1.ext ABCDE...ABCDE  OK
file2.ext DEFGH...DEFGH  OK
file3.ext JKLMN...JKLMN  OK
SFV example.sfv [3/3] OK

file1.ext ABCDE...ABCDE  OK
file2.ext DEFGH...DEFGH  OK
file3.ext JKLMN...JKXXX  FAIL
SFV example.sfv [2/3] FAIL

or just:

file1.ext ABCDE...ABCDE  OK
file2.ext DEFGH...DEFGH  OK
file3.ext JKLMN...JKLMN  OK
SFV example.sfv ALL OK

I do like the current minimalistic output though, it works great for scripting.
That being said, this might be discussion for another topic, I think we can mark this feature request as completed.