Update publish workflows

Author: Alexander01998

.github/workflows/multi_publish.yml

@@ -6,30 +6,26 @@ on:
     inputs:
       mod_version:
         description: "Mod version (without v or -MC)"
-        required: true
         type: string
+        required: true
       branches:
         description: "Space-separated list of branches to publish from"
-        required: true
         type: string
+        required: true
       publish_curseforge:
         description: "Publish to CurseForge"
-        required: true
         type: boolean
         default: true
       announce_update:
         description: "Announce as an update on WurstForum"
-        required: true
         type: boolean
         default: false
       announce_ports:
         description: "Announce as ports on WurstForum"
-        required: true
         type: boolean
         default: false
       dry_run:
         description: "Dry-run mode (don't actually publish anything)"
-        required: false
         type: boolean
         default: false
 
@@ -52,6 +48,15 @@ jobs:
         JSON_ARRAY="[${quoted_branches%,}]"
         echo "branches=$JSON_ARRAY" >> "$GITHUB_OUTPUT"
         echo "Branches: $JSON_ARRAY" >> "$GITHUB_STEP_SUMMARY"
+    - name: Verify mod_version is as expected
+      run: |
+        expected_prefix="${{ inputs.mod_version }}-MC"
+        for branch in ${{ inputs.branches }}; do
+          url="https://raw.githubusercontent.com/${{ github.repository }}/${branch}/gradle.properties"
+          actual=$(curl -sf "$url" | grep "^mod_version=" | cut -d'=' -f2)
+          echo "$branch: $actual"
+          [[ "$actual" == "$expected_prefix"* ]] || { echo "::error::Expected $expected_prefix*, got $actual"; exit 1; }
+        done
 
   publish_each:
     runs-on: ubuntu-latest
@@ -67,7 +72,6 @@ jobs:
       fail-fast: true
       matrix:
         branch: ${{ fromJson(needs.prepare.outputs.branches) }}
-    # TODO: Maybe also verify that the mod_version in each branch is as expected before publishing?
     steps:
     - name: Trigger publish workflow
       uses: Wurst-Imperium/dispatch-and-wait@v1

.github/workflows/publish.yml

@@ -6,30 +6,26 @@ on:
     inputs:
       close_milestone:
         description: "Close milestone"
-        required: true
         type: boolean
         default: true
       upload_backups:
         description: "Upload to backups server"
-        required: true
         type: boolean
         default: true
       publish_github:
         description: "Publish to GitHub"
-        required: true
         type: boolean
         default: true
       publish_curseforge:
         description: "Publish to CurseForge"
-        required: true
         type: boolean
         default: true
       update_website:
         description: "Update wimods.net post (only works if there already is one)"
-        required: false
         type: boolean
         default: false
       distinct_id:
+        type: string
         required: false
 
 permissions:
@@ -74,6 +70,7 @@ jobs:
       run: ./gradlew build --stacktrace
 
     - name: Create and push tag
+      if: ${{ github.ref_type != 'tag' }}
       run: |
         MOD_VERSION=$(grep "^mod_version=" gradle.properties | cut -d'=' -f2 | tr -d ' \r')
         git config --global user.name "Wurst-Bot"
@@ -140,6 +137,7 @@ jobs:
             "mod_version": "${{ steps.website_inputs.outputs.mod_version }}",
             "mc_version": "${{ steps.website_inputs.outputs.mc_version }}",
             "fapi_version": "${{ steps.website_inputs.outputs.fapi_version }}",
-            "file_id": "${{ steps.cf_file_id.outputs.file_id }}"
+            "file_id": "${{ steps.cf_file_id.outputs.file_id }}",
+            "modrinth": "false"
           }
         run_timeout_seconds: 600  # 10 minutes