FeedAuraHack: implement auto shears#1273
FeedAuraHack: implement auto shears#1273TheMcSebi wants to merge 4 commits intoWurst-Imperium:masterfrom
Conversation
|
|
| .filter(e -> player.distanceToSqr(e) <= rangeSq) | ||
| .filter(e -> e.isFood(heldStack)).filter(Animal::canFallInLove); | ||
| Stream<Animal> stream = EntityUtils.getValidAnimals(); | ||
|
|
There was a problem hiding this comment.
The name feels so misleading. It is a FeedAuraHack, but it can be used to either feeding or shearing. It is trying to do two different things in one functionality. Perhaps there should be a more generic class with more generic names.
There was a problem hiding this comment.
I agree, FeedAura shearing stuff doesn't make sense. It should either be two separate FeedAura/ShearAura hacks or a single RightClickAura hack with settings. I'm leaning towards two separate hacks.
There was a problem hiding this comment.
I totally agree, i just put it there because this was presumably the easiest point to implement this and i quickly needed some wool :)
|
I didn't want to copy all the code, so I put most of the code into a parent class, even though I do not know if this makes the most sense regarding architecture. The current solution doesn't disable the other of the two inheriting aura hacks on enable, while other auras get disabled. |
|
Maybe it would make the most sense to abstract all aurahacks into a sub class and disable them accordingly, but I don't want to refactor your entire client e.g. for(Hack hack : WURST.getHax().getAllHax())
if(hack != this && hack instanceof GenericAuraHack)
hack.setEnabled(false); |
|
This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks. Pull requests should be closed if:
|
|
This would be ready for a review |
|
This pull request has been open for a while with no recent activity. If you're still working on this or waiting for a review, please add a comment or commit within the next 7 days to keep it open. Otherwise, the pull request will be automatically closed to free up time for other tasks. Pull requests should be closed if:
|
4 participants
Implements auto-shears into feed aura
Description
Simple addition to the feed aura hack to automatically shear all sheep in range.
Implemented because I needed it.
Just a simple POC, maybe there are more use cases for right clicking entities. Also a toggle in the hack settings might be appropriate.
If you want this feature in, feel free to provide feedback.
Testing
I tested the change by going to my sheep farm with shears and enabling FeedAura