Skip to content

Boot NXP-LPC55#32

Open
genan2003 wants to merge 8 commits into
WyliodrinEmbeddedIoT:masterfrom
genan2003:add-lpc55-support
Open

Boot NXP-LPC55#32
genan2003 wants to merge 8 commits into
WyliodrinEmbeddedIoT:masterfrom
genan2003:add-lpc55-support

Conversation

@genan2003

Copy link
Copy Markdown

Pull Request Overview

This pull request adds the booting and flashing of NXP-LPC55

TODO or Help Wanted

The next tasks are #20, #19 and #28

Formatting

  • Ran make prepush.

JADarius added 3 commits June 30, 2025 10:39
This commits adds the code for the Cortex-M33 architecture.
It also adds the possibility to use the Non-Secure alias of the MPU
This commit adds the code for the RP2350 MCU and
the RP2350 board that uses that MCU.
At the moment, the board supports the following:
- UART Console;
- Timers;
- GPIO with interrupts.
It also changes `tock_kernel_layout.ld` because of an apparent
bug with arm-none-eabi-objcopy.
This commit changes the `cortex-m33` crate to use `cortex-v7m`,
because the v7m is compatible with v8m, and there is no reason to
just have 2 crates with the same code.
@github-actions github-actions Bot added the kernel label Jul 8, 2025
@genan2003 genan2003 mentioned this pull request Jul 8, 2025
1 task
@alexandruradovici

Copy link
Copy Markdown

Looks much bettee, please make sure the tests pass.

@genan2003 genan2003 mentioned this pull request Jul 8, 2025
7 tasks
@genan2003

Copy link
Copy Markdown
Author

Looks much bettee, please make sure the tests pass.

Some of the tests fail, because they don't have a license header. What can we do?

@alexandruradovici

Copy link
Copy Markdown

Add a license header :)

@genan2003

Copy link
Copy Markdown
Author

Add a license header :)

What license header should we add?

@alexandruradovici

Copy link
Copy Markdown

Take a look at the other files in Tock.

@genan2003

Copy link
Copy Markdown
Author

Take a look at the other files in Tock.

Ok, I will look into them and I will add the license headers.

@genan2003 genan2003 linked an issue Jul 8, 2025 that may be closed by this pull request
7 tasks
@genan2003 genan2003 force-pushed the add-lpc55-support branch from 7103d6b to 9696aed Compare July 8, 2025 21:00
@genan2003 genan2003 moved this to In Progress in Open Source Internship 2025 Jul 8, 2025
@genan2003 genan2003 moved this from In Progress to In Review in Open Source Internship 2025 Jul 8, 2025
@genan2003 genan2003 force-pushed the add-lpc55-support branch from 7a1eaae to b2056e8 Compare July 8, 2025 21:15

@alexandruradovici alexandruradovici left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please base your PR on this branch tock#4416.

@genan2003

Copy link
Copy Markdown
Author

Please base your PR on this branch tock#4416.

So to make a PR on the main Tock repo?

@genan2003 genan2003 force-pushed the add-lpc55-support branch from b2056e8 to 70b507b Compare July 8, 2025 21:31
@genan2003 genan2003 force-pushed the add-lpc55-support branch from 70b507b to b4b9a92 Compare July 9, 2025 07:37
@github-actions github-actions Bot removed the kernel label Jul 9, 2025
@genan2003 genan2003 force-pushed the add-lpc55-support branch from 64accb2 to cf14f27 Compare July 9, 2025 07:58

@alexandruradovici alexandruradovici left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we need to add gpio, goio inteerupts, timee and uart to be able to upstream it.

@genan2003

Copy link
Copy Markdown
Author

Looks good, we need to add gpio, goio inteerupts, timee and uart to be able to upstream it.

Ok, today I started working on GPIO and @GameSkyRO works on UART.

@alexandruradovici

Copy link
Copy Markdown

I suggest that you both start from this branch and send pull requests to it.

@genan2003

Copy link
Copy Markdown
Author

I suggest that you both start from this branch and send pull requests to it.

Ok, we will make this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boot NXP-LPC55

4 participants