Skip to content

add(lpc55):gpio and alarm support#46

Open
genan2003 wants to merge 2 commits into
WyliodrinEmbeddedIoT:masterfrom
genan2003:lpc55-alarm
Open

add(lpc55):gpio and alarm support#46
genan2003 wants to merge 2 commits into
WyliodrinEmbeddedIoT:masterfrom
genan2003:lpc55-alarm

Conversation

@genan2003
Copy link
Copy Markdown

Pull Request Overview

This commit introduces the initial Alarm driver for the NXP LPC55 series microcontroller. The driver provides the foundational API for configuring and managing Alarm functionality.

Testing Strategy

This pull request was tested by blinking and LED from the board(flashing the blink example from libtock-c)

TODO or Help Wanted

This pull request still needs...

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

Copy link
Copy Markdown

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please add a Readme.md to each new crate.

Comment thread boards/lpc55s69-evk/src/main.rs Outdated
@genan2003
Copy link
Copy Markdown
Author

Looks good, please add a Readme.md to each new crate.

Done.

@alexandruradovici
Copy link
Copy Markdown

Please fix the pipeline errors.

@genan2003
Copy link
Copy Markdown
Author

Please fix the pipeline errors.

Done. The pipeline with nb dependency fails, probably from the cortex_m_semihosting, but when we will remove it will not fail.

@alexandruradovici
Copy link
Copy Markdown

There should be no external dependencies.

Comment thread boards/lpc55s69-evk/Cargo.toml Outdated
@genan2003
Copy link
Copy Markdown
Author

There should be no external dependencies.

I removed all external dependencies.

Comment thread boards/lpc55s69-evk/src/io.rs Outdated
Comment thread boards/lpc55s69-evk/src/io.rs Outdated
Comment thread rust-toolchain.toml Outdated
@genan2003
Copy link
Copy Markdown
Author

@alexandruradovici why is not good to use the target thumbv8m.main-none-eabihf since the kernel compiles and the examples form libtock-c are working good?

@alexandruradovici
Copy link
Copy Markdown

alexandruradovici commented Sep 11, 2025

The hf means that it might use hardware floating point, which not supported by the kernel. If the compiler inserts and floating point, the context switch will fail.

Screenshot 2025-09-11 at 15 07 31 Screenshot 2025-09-11 at 15 08 13

@genan2003
Copy link
Copy Markdown
Author

The hf means that it might use hardware floating point, which not supported by the kernel. If the compiler inserts and floating point, the context switch will fail.

Ok, that makes sense.

@alexandruradovici
Copy link
Copy Markdown

I added some images that point out the difference in exception handling.

@genan2003
Copy link
Copy Markdown
Author

I added some images that point out the difference in exception handling.

Now I see the problem of using the hf target. We can encounter other problems when we are using it.

@genan2003
Copy link
Copy Markdown
Author

@alexandruradovici what do I have to do next?

@alexandruradovici
Copy link
Copy Markdown

Did you delete the hf?

@genan2003
Copy link
Copy Markdown
Author

genan2003 commented Sep 11, 2025

Did you delete the hf?

Yes, I deleted it. Also, I make the modification in the .cargo folder of the board in order to use the target without hf.

Comment thread boards/lpc55s69-evk/src/io.rs Outdated
Comment thread boards/lpc55s69-evk/src/io.rs Outdated
Copy link
Copy Markdown

@alexandruradovici alexandruradovici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can open the PR to upstream.

@genan2003
Copy link
Copy Markdown
Author

@alexandruradovici can you, please, approve this PR in order to send the PR to upstream? I deleted some comments and the initial approve was dismissed.

Comment thread doc/wg/core/notes/core-notes-2025-08-06.md
@genan2003 genan2003 force-pushed the lpc55-alarm branch 2 times, most recently from c7dc467 to c075585 Compare September 16, 2025 13:20
Signed-off-by: user3345 <81963672+genan2003@users.noreply.github.com>
Signed-off-by: user3345 <81963672+genan2003@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants