Custom ability target styles v2

[robojumper]

Fixes #763, resubmission of #762.

[robojumper]

I personally have no use for this, but #762 in limbo bothered me, cc @Xymanek. #762 says LWotC needs this in some form, cc @pledbrook.

[Xymanek]

Could we use CH_MAKE_QUICKSORT from #809 since this is so performance critical?

[robojumper]

Needs profiling. My intuition is that anything but .Sort() will worsen performance. How many available targets do we expect? Note that #809 currently already cuts off at 15 elements to use InsertionSort.

[pledbrook]

I take it this has nothing to do with targeting methods?

[pledbrook]

LWOTC has a X2AbilityMultiTarget_Cone_LWFlamethrower class that is a custom, UC targeting style. It seems to work as it is. Should I change something to start making use of this change?

[robojumper]

I take it this has nothing to do with targeting methods?

For cursor-targeted abilities, the multi-target style builds the multi targets for the cursor target created by the targeting method. For everything else, the target style builds the initial target list, the multi-target style builds the multi-targets for every target, and the targeting method only selects a particular target.

[robojumper]

X2AbilityMultiTarget_Cone_LWFlamethrower should work as is already and doesn't benefit from any change in this PR since it's cursor-targeted. If I were to suggest a change, it's this TODO:

https://github.com/long-war-2/lwotc/blob/db7ff997a5882cb4950a07861026f8e90317bd24/LongWarOfTheChosen/Src/LW_Overhaul/Classes/X2AbilityMultiTarget_Cone_LWFlamethrower.uc#L78-L83

UpdateParameters basically modifies the template, so it's a bit of a hack.

[Iridar]

Wait, so it's all done and ready? Just needs a review? Imma get into that soon as I have time.

[pledbrook]

I mean, it looks fine to me. I think it just requires some testing to ensure it doesn't break anything. Could use it for the next LWOTC release so that it does get some level of playtesting.

[Iridar]

I have tested this a while ago, but forgot to report in. It works perfectly fine and is sufficient to do what I wanted to do, which is to make a version of Faceoff that can target variable number of targets based on pistol's current ammo.