fix(installer): prevent column-shift corruption and autoloader failure on fresh install (#16)

* fix(installer): prevent column-shift corruption and autoloader failure on fresh install

  Use explicit column names in every INSERT in makedata.php to prevent silent
  data corruption when columns are added to core tables. The modules table gained
  show_in_menu after the positional VALUES list was written, shifting dirname to
  '0' and isactive to 0 for the System module — which broke the entire install:
  the System module appeared as an optional checkbox (issue #12), selecting it
  caused duplicate template insertion errors (issue #13), and skipping it left
  XOOPS non-functional.

  Also replace Xmf\Request with raw $_COOKIE in the install wizard bootstrap
  (issue #11). The XMF autoloader is not reliably available at that point when
  xoops_lib has been relocated outside the webroot — mainfile.php does not exist
  yet on the first page load, so the autoloader search paths all fail.

  Fixes #11, fixes #12, fixes #13

* fix(installer): add explicit columns to remaining menu-seed permission inserts

  The two group_permission inserts in system_menu_install_seed_defaults()
  were still using positional VALUES without a column list. Also initialize
  $module_array before the system-dirname filter loop in searchform.php to
  prevent an undefined variable warning when all modules are filtered out.

Author: mambax7

htdocs/include/searchform.php

@@ -41,14 +41,19 @@
     $criteria = new CriteriaCompo();
     $criteria->add(new Criteria('hassearch', 1));
     $criteria->add(new Criteria('isactive', 1));
+    $criteria->add(new Criteria('dirname', 'system', '<>'));
     if (!empty($available_modules)) {
         $criteria->add(new Criteria('mid', '(' . implode(',', $available_modules) . ')', 'IN'));
     }
     /** @var XoopsModuleHandler $module_handler */
     $module_handler = xoops_getHandler('module');
     $mods_checkbox->addOptionArray($module_handler->getList($criteria));
 } else {
+    $module_array = [];
     foreach ($modules as $mid => $module) {
+        if ('system' === $module->getVar('dirname')) {
+            continue;
+        }
         $module_array[$mid] = $module->getVar('name');
     }
     $mods_checkbox->addOptionArray($module_array);

htdocs/install/class/installwizard.php

@@ -41,8 +41,11 @@ public function xoInit()
             $_SERVER['REQUEST_URI'] = $_SERVER['PHP_SELF'];
         }
 
-        // Load the main language file
-        $installLang = \Xmf\Request::getString('xo_install_lang', '', 'COOKIE');
+        // Load the main language file.
+        // Use raw $_COOKIE here — the XMF autoloader is not reliably available
+        // this early in the install bootstrap (xoops_lib may be relocated and
+        // mainfile.php doesn't exist yet on the first page load).
+        $installLang = isset($_COOKIE['xo_install_lang']) ? trim((string) $_COOKIE['xo_install_lang']) : '';
         $this->initLanguage(!empty($installLang) ? $installLang : 'english');
         // Setup pages
         $pages = include __DIR__ . '/../include/page.php';