update modern theme (#14)

* updated KPI for active modules

* show dashboard only for htdocs/admin.php

* Update module definitions for clarity

* Improve comments for active modules assignment

Add comments to clarify admin-only module logic.

* Update htdocs/modules/system/themes/modern/modern.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Michael Beck <mambax7@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

htdocs/modules/system/themes/modern/language/english/main.php

@@ -20,9 +20,10 @@
 
 // -- Dashboard: KPI Cards --
 define('_MODERN_TOTAL_USERS', 'Total Users');
-define('_MODERN_NEW_THIS_MONTH', 'new this month');
+define('_MODERN_NEW_THIS_MONTH', 'New this month');
 define('_MODERN_ACTIVE_MODULES', 'Active Modules');
-define('_MODERN_INACTIVE', 'inactive');
+define('_MODERN_ACTIVE_MODULES_USERS', 'User-Facing Modules');
+define('_MODERN_ACTIVE_MODULES_ADMINS', 'Admin-Only Modules');
 define('_MODERN_ACTIVE_USERS', 'Active Users');
 define('_MODERN_LAST_30_DAYS', 'Last 30 days');
 define('_MODERN_SERVER_LOAD', 'Server Load');

htdocs/modules/system/themes/modern/modern.php

@@ -243,18 +243,21 @@ private function getModuleStats(&$tpl)
     {
         /** @var XoopsModuleHandler $module_handler */
         $module_handler = xoops_getHandler('module');
+
         $criteria = new CriteriaCompo();
-        $criteria->add(new Criteria('hasmain', 1));
+        // active modules
         $criteria->add(new Criteria('isactive', 1));
-
         $active_modules = $module_handler->getCount($criteria);
-
-        $criteria_all = new Criteria('dirname', '', '!=');
-        $total_modules = $module_handler->getCount($criteria_all);
+        // active modules for user side
+        $criteria->add(new Criteria('hasmain', 1));
+        $active_modules_user = $module_handler->getCount($criteria);
 
         $tpl->assign('active_modules', $active_modules);
-        $tpl->assign('total_modules', $total_modules);
-        $tpl->assign('inactive_modules', $total_modules - $active_modules);
+        $tpl->assign('active_modules_user', $active_modules_user);
+        // Modules without a frontend entry (hasmain=0) are admin-only by XOOPS design.
+        // Every active module has at least hasmain=1 or hasadmin=1, so this subtraction
+        // equals querying isactive=1 AND hasmain=0 without an extra DB round-trip.
+        $tpl->assign('active_modules_admin', $active_modules - $active_modules_user);
     }
 
     /**

htdocs/modules/system/themes/modern/xotpl/xo_dashboard.tpl

@@ -1,5 +1,5 @@
 <{* Dashboard shown only on admin.php homepage *}>
-<{if $xoops_dirname == 'system' && !isset($smarty.get.fct)}>
+<{if $xoops_page == 'admin'}>
 <section class="dashboard-section">
     <!-- KPI Cards -->
     <div class="kpis">
@@ -16,7 +16,8 @@
             <div class="kpi-label"><{$smarty.const._MODERN_ACTIVE_MODULES}></div>
             <div class="kpi-value"><{$active_modules}></div>
             <div class="kpi-change">
-                <span><{$inactive_modules}> <{$smarty.const._MODERN_INACTIVE}></span>
+                <span><{$smarty.const._MODERN_ACTIVE_MODULES_USERS}>: <{$active_modules_user}><br>
+                <{$smarty.const._MODERN_ACTIVE_MODULES_ADMINS}>: <{$active_modules_admin}></span>
             </div>
         </div>