feat(deleteUser): enhance delete user functionality with proper response handling

Author: Theo-lbg

src/main/java/com/xpeho/spring_boot_java_random_user/domain/usecases/DeleteUserByIdUseCase.java

@@ -1,6 +1,7 @@
 package com.xpeho.spring_boot_java_random_user.domain.usecases;
 
 import com.xpeho.spring_boot_java_random_user.domain.services.LocalUserService;
+import com.xpeho.spring_boot_java_random_user.domain.exceptions.UserNotFoundException;
 import org.springframework.stereotype.Service;
 
 @Service
@@ -12,6 +13,7 @@ public DeleteUserByIdUseCase(LocalUserService userService) {
     }
 
     public void execute(long id) {
+        userService.getById(id).orElseThrow(() -> new UserNotFoundException(id));
         userService.deleteById(id);
     }
 }

src/main/java/com/xpeho/spring_boot_java_random_user/presentation/controllers/UserController.java

@@ -132,7 +132,7 @@ ResponseEntity<List<UserEntity>> filterUsers(
     @ApiResponse(responseCode = "204", description = "User successfully deleted")
     @ApiResponse(responseCode = "404", description = "The requested user does not exist")
     @ApiResponse(responseCode = "500", description = "Internal server error")
-    void deleteUserById(
+        ResponseEntity<Void> deleteUserById(
             @PathVariable
             int id
     );

src/main/java/com/xpeho/spring_boot_java_random_user/presentation/handlers/UserHandler.java

@@ -110,11 +110,13 @@ public ResponseEntity<List<UserEntity>> filterUsers(
     }
 
     @Override
-    public void deleteUserById(int id) {
+    public ResponseEntity<Void> deleteUserById(int id) {
         try {
             deleteUserUseCase.execute(id);
+            return ResponseEntity.noContent().build();
         } catch (UserNotFoundException e) {
             logUserNotFound(e);
+            return ResponseEntity.status(HttpStatus.NOT_FOUND).build();
         }
     }
 

src/test/java/com/xpeho/spring_boot_java_random_user/presentation/UserHandlerTest.java

@@ -149,9 +149,12 @@ void shouldReturnCreatedWhenCreateUserSucceeds() {
     @DisplayName("Should return 204 when deleteUserById succeeds")
     void shouldReturnNoContentWhenDeleteUserByIdSucceeds() {
         int userId = 42;
+        doNothing().when(deleteUserUseCase).execute(userId);
 
-        userHandler.deleteUserById(userId);
+        ResponseEntity<Void> response = userHandler.deleteUserById(userId);
 
+        assertEquals(HttpStatus.NO_CONTENT, response.getStatusCode());
+        assertNull(response.getBody());
         verify(deleteUserUseCase, times(1)).execute(userId);
     }
 
@@ -161,8 +164,10 @@ void shouldLogWarningWhenDeleteUserByIdFails() {
         int userId = 123;
         doThrow(new UserNotFoundException(userId)).when(deleteUserUseCase).execute(userId);
 
-        userHandler.deleteUserById(userId);
+        ResponseEntity<Void> response = userHandler.deleteUserById(userId);
 
+        assertEquals(HttpStatus.NOT_FOUND, response.getStatusCode());
+        assertNull(response.getBody());
         verify(deleteUserUseCase, times(1)).execute(userId);
     }
 

src/test/java/feature/SpringIntegrationTest.java

@@ -7,6 +7,7 @@
 import org.springframework.boot.resttestclient.autoconfigure.AutoConfigureTestRestTemplate;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.boot.test.web.server.LocalServerPort;
+import org.springframework.http.HttpMethod;
 import org.springframework.http.HttpEntity;
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.MediaType;
@@ -49,7 +50,6 @@ protected void executePost(String path, Object payload) {
 
     protected void executeDelete(String path) {
         String url = "http://localhost:" + port + path;
-        restTemplate.delete(url);
-        latestResponse = ResponseEntity.noContent().build();
+        latestResponse = restTemplate.exchange(url, HttpMethod.DELETE, null, String.class);
     }
 }