test(cucumber_fetch_and_save): fix the exception handling

Author: romainVanhee

src/main/java/com/xpeho/spring_boot_java_random_user/presentation/exceptions/GlobalExceptionHandler.java

@@ -22,7 +22,7 @@ public ResponseEntity<ErrorResponse> handleConstraintViolationException(Constrai
                 .findFirst()
                 .orElse(ex.getMessage());
         logger.warn("Constraint violation: {}", message);
-        return buildErrorResponse("INVALID_PARAMETER", message, HttpStatus.BAD_REQUEST);
+        return buildErrorResponse("INVALID_PAGINATION", message, HttpStatus.BAD_REQUEST);
     }
 
     @ExceptionHandler(InvalidPaginationException.class)

src/main/java/com/xpeho/spring_boot_java_random_user/presentation/handlers/UserHandler.java

@@ -6,7 +6,6 @@
 import com.xpeho.spring_boot_java_random_user.domain.entities.UserRequest;
 import com.xpeho.spring_boot_java_random_user.domain.enums.Gender;
 import com.xpeho.spring_boot_java_random_user.domain.enums.UserSource;
-import com.xpeho.spring_boot_java_random_user.domain.exceptions.InvalidPaginationException;
 import com.xpeho.spring_boot_java_random_user.domain.exceptions.UserNotFoundException;
 import com.xpeho.spring_boot_java_random_user.domain.usecases.*;
 import com.xpeho.spring_boot_java_random_user.presentation.controllers.UserController;
@@ -56,12 +55,6 @@ public UserHandler(
 
     @Override
     public ResponseEntity<UserResponseDTO> getRandomUsers(int page, int size, UserSource source) {
-        if (page < 1) {
-            throw new InvalidPaginationException("Page must be greater than or equal to 1. Requested: " + page);
-        }
-        if (size < 1 || size > 30) {
-            throw new InvalidPaginationException("Page size must be between 1 and 30. Requested: " + size);
-        }
         try {
             PaginatedUsers result = fetchAndSaveRandomUsersUseCase.execute(page, size, source);
             UserResponseDTO response = new UserResponseDTO(
@@ -72,7 +65,7 @@ public ResponseEntity<UserResponseDTO> getRandomUsers(int page, int size, UserSo
             );
             return ResponseEntity.ok(response);
         } catch (IOException e) {
-            logger.error("Error fetching random users: {}", e.getMessage());
+            logger.error("Error fetching random users", e);
             return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).build();
         }
     }
@@ -126,6 +119,6 @@ public void deleteUserById(int id) {
     }
 
     private void logUserNotFound(UserNotFoundException e) {
-        logger.warn(USER_NOT_FOUND_LOG, e.getMessage());
+        logger.warn(USER_NOT_FOUND_LOG, e);
     }
 }

src/test/java/com/xpeho/spring_boot_java_random_user/presentation/UserHandlerTest.java

@@ -6,16 +6,13 @@
 import com.xpeho.spring_boot_java_random_user.domain.entities.UserRequest;
 import com.xpeho.spring_boot_java_random_user.domain.enums.Gender;
 import com.xpeho.spring_boot_java_random_user.domain.enums.UserSource;
-import com.xpeho.spring_boot_java_random_user.domain.exceptions.InvalidPaginationException;
 import com.xpeho.spring_boot_java_random_user.domain.exceptions.UserNotFoundException;
 import com.xpeho.spring_boot_java_random_user.domain.usecases.*;
 import com.xpeho.spring_boot_java_random_user.presentation.handlers.UserHandler;
 import com.xpeho.spring_boot_java_random_user.presentation.dto.UserResponseDTO;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.CsvSource;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 
@@ -82,19 +79,6 @@ void shouldReturnInternalServerErrorWhenGetRandomUsersFails() throws IOException
         verify(fetchAndSaveRandomUsersUseCase, times(1)).execute(page, size, UserSource.RANDOM_USER);
     }
 
-    @ParameterizedTest
-    @CsvSource({
-            "1, 31",
-            "0, 10",
-            "1, 0"
-    })
-    @DisplayName("Should throw InvalidPaginationException for invalid pagination inputs")
-    void shouldThrowInvalidPaginationExceptionForInvalidPaginationInputs(int page, int size) throws IOException {
-        assertThrows(InvalidPaginationException.class, () -> userHandler.getRandomUsers(page, size, UserSource.DUMMY));
-        verify(fetchAndSaveRandomUsersUseCase, never()).execute(page, size, UserSource.DUMMY);
-    }
-
-
     @Test
     @DisplayName("Should return 200 and user when getUserById succeeds")
     void shouldReturnOkWhenGetUserByIdSucceeds() {

src/test/java/com/xpeho/spring_boot_java_random_user/presentation/exceptions/GlobalExceptionHandlerTest.java

@@ -34,7 +34,7 @@ void shouldReturnBadRequestWhenConstraintViolationException() {
 
         assertEquals(HttpStatus.BAD_REQUEST, response.getStatusCode());
         assertNotNull(response.getBody());
-        assertEquals("INVALID_PARAMETER", response.getBody().error());
+        assertEquals("INVALID_PAGINATION", response.getBody().error());
         assertEquals(400, response.getBody().status());
         assertTrue(response.getBody().message().contains("must be less than or equal to 30"));
     }