Skip to content

Commit d39b342

Browse files
committed
feat(api): encapsulate results in RandomUserResponse and update related methods
1 parent 8914114 commit d39b342

6 files changed

Lines changed: 12 additions & 8 deletions

File tree

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
package com.xpeho.spring_boot_java_random_user.data.models.api;
22

33
public class RandomUserResponse {
4-
public RandomUserResultDAO[] results;
4+
private RandomUserResultDAO[] results;
5+
6+
public RandomUserResultDAO[] getResults() {
7+
return results;
8+
}
9+
10+
public void setResults(RandomUserResultDAO[] results) {
11+
this.results = results;
12+
}
513
}

src/main/java/com/xpeho/spring_boot_java_random_user/data/services/UserServiceImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
import java.util.List;
1111
import java.util.stream.StreamSupport;
12-
import java.util.stream.Collectors;
1312

1413
@Service
1514

src/main/java/com/xpeho/spring_boot_java_random_user/data/sources/api/RandomUserProviderImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ public List<UserEntity> fetchRandomUsers(int count) throws IOException {
2727
if (!response.isSuccessful() || response.body() == null) {
2828
throw new IOException("Failed to fetch users: " + response.code());
2929
}
30-
return Arrays.stream(response.body().results)
31-
.map(userConverter::fromApiModel)
32-
.toList();
30+
return Arrays.stream(response.body().getResults())
31+
.map(userConverter::fromApiModel)
32+
.toList();
3333
}
3434
}

src/main/java/com/xpeho/spring_boot_java_random_user/presentation/controllers/UserController.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import io.swagger.v3.oas.annotations.Operation;
1414
import io.swagger.v3.oas.annotations.Parameter;
1515
import io.swagger.v3.oas.annotations.responses.ApiResponse;
16-
import io.swagger.v3.oas.annotations.responses.ApiResponses;
1716
import io.swagger.v3.oas.annotations.tags.Tag;
1817

1918

src/main/java/com/xpeho/spring_boot_java_random_user/presentation/handlers/UserHandler.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
import java.io.IOException;
1515
import java.util.List;
16-
import java.util.Map;
1716

1817
import static java.util.Collections.emptyList;
1918

src/test/java/com/xpeho/spring_boot_java_random_user/domain/usecases/FetchAndSaveRandomUsersUseCaseTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import com.xpeho.spring_boot_java_random_user.domain.services.UserService;
66
import org.junit.jupiter.api.BeforeEach;
77
import org.junit.jupiter.api.Test;
8-
import org.mockito.Mockito;
98

109
import java.io.IOException;
1110
import java.util.Collections;

0 commit comments

Comments
 (0)