Skip to content

fix(all-tests): change the configuration and add information in .env#72

Merged
MayuriXx merged 1 commit into
mainfrom
fix/all-tests
Apr 16, 2026
Merged

fix(all-tests): change the configuration and add information in .env#72
MayuriXx merged 1 commit into
mainfrom
fix/all-tests

Conversation

@MayuriXx
Copy link
Copy Markdown
Collaborator

#70

Copilot AI review requested due to automatic review settings April 16, 2026 12:39
@MayuriXx MayuriXx linked an issue Apr 16, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates test and container configuration to address failing test suites/CI (Issue #70) by adjusting Testcontainers usage, Docker Compose image tags, and environment templates.

Changes:

  • Adjusts a container-based Spring Boot test to use PostgreSQL 17 and removes the test profile.
  • Updates Testcontainers Maven coordinates/version and Testcontainers dependencies in pom.xml.
  • Simplifies Docker Compose header and updates Postgres image tag; extends .env.template with H2 variables.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
src/test/java/com/xpeho/spring_boot_java_random_user/presentation/UserGetByIdContainerTest.java Tweaks Testcontainers-based integration test configuration (profile + Postgres image).
pom.xml Updates Testcontainers BOM version and changes Testcontainers dependency artifactIds.
docker-compose.yml Removes compose version and changes Postgres image tag.
.env.template Documents H2 env vars expected by test configuration.
Comments suppressed due to low confidence (1)

src/test/java/com/xpeho/spring_boot_java_random_user/presentation/UserGetByIdContainerTest.java:30

  • Removing @activeprofiles("test") means this test will no longer pick up src/test/resources/application-test.properties. Since src/main/resources/application.properties requires Liquibase placeholders (LB_CHANGELOG/LB_SCHEMA) without defaults, the Spring context can fail to start unless those are provided elsewhere. Consider explicitly disabling Liquibase for this test (e.g., via @SpringBootTest properties) or providing the needed Liquibase properties in the test config.
@SpringBootTest(
        webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT,
        properties = {
                "spring.sql.init.mode=never",
                "spring.jpa.hibernate.ddl-auto=create-drop"
        }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pom.xml
Comment thread pom.xml
Comment thread docker-compose.yml
Comment thread .env.template
@sonarqube-xpeho
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@Theo-lbg Theo-lbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MayuriXx MayuriXx merged commit 4280e60 into main Apr 16, 2026
9 checks passed
@MayuriXx MayuriXx deleted the fix/all-tests branch April 16, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix all tests

4 participants