fix(all-tests): change the configuration and add information in .env#72
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
Updates test and container configuration to address failing test suites/CI (Issue #70) by adjusting Testcontainers usage, Docker Compose image tags, and environment templates.
Changes:
- Adjusts a container-based Spring Boot test to use PostgreSQL 17 and removes the
testprofile. - Updates Testcontainers Maven coordinates/version and Testcontainers dependencies in
pom.xml. - Simplifies Docker Compose header and updates Postgres image tag; extends
.env.templatewith H2 variables.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/test/java/com/xpeho/spring_boot_java_random_user/presentation/UserGetByIdContainerTest.java |
Tweaks Testcontainers-based integration test configuration (profile + Postgres image). |
pom.xml |
Updates Testcontainers BOM version and changes Testcontainers dependency artifactIds. |
docker-compose.yml |
Removes compose version and changes Postgres image tag. |
.env.template |
Documents H2 env vars expected by test configuration. |
Comments suppressed due to low confidence (1)
src/test/java/com/xpeho/spring_boot_java_random_user/presentation/UserGetByIdContainerTest.java:30
- Removing @activeprofiles("test") means this test will no longer pick up src/test/resources/application-test.properties. Since src/main/resources/application.properties requires Liquibase placeholders (LB_CHANGELOG/LB_SCHEMA) without defaults, the Spring context can fail to start unless those are provided elsewhere. Consider explicitly disabling Liquibase for this test (e.g., via
@SpringBootTestproperties) or providing the needed Liquibase properties in the test config.
@SpringBootTest(
webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT,
properties = {
"spring.sql.init.mode=never",
"spring.jpa.hibernate.ddl-auto=create-drop"
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
profotoce59
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





#70