feat(springSecurity): add spring security in app by Theo-lbg · Pull Request #79 · XPEHO/spring_boot_java_random_user

Theo-lbg · 2026-04-23T14:32:58Z

No description provided.

Copilot

Pull request overview

This PR introduces Spring Security (HTTP Basic) to protect the application’s endpoints, adds in-memory users/roles configured via properties/environment variables, and updates tests + documentation to work with authentication.

Changes:

Added Spring Security dependency plus a SecurityFilterChain, in-memory UserDetailsService, and BCrypt encoder.
Added security-related configuration properties for main and test profiles; updated integration/container tests to send Basic Auth.
Updated CI workflows and documentation/environment templates to reflect the new security configuration.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`src/main/java/com/xpeho/spring_boot_java_random_user/config/SecurityConfig.java`	Adds Spring Security configuration (Basic auth, stateless, in-memory users).
`src/main/java/com/xpeho/spring_boot_java_random_user/config/SecurityConfigurationException.java`	Adds a dedicated runtime exception for security filter chain build failures.
`src/main/resources/application.properties`	Introduces `app.security.*` properties backed by env vars.
`pom.xml`	Adds `spring-boot-starter-security`.
`src/test/resources/application-test.properties`	Adds test security credentials and datasource defaults for the test profile.
`src/test/java/feature/SpringIntegrationTest.java`	Updates Cucumber integration test base to use Basic Auth.
`src/test/java/com/xpeho/spring_boot_java_random_user/presentation/UserGetByIdContainerTest.java`	Updates container test to authenticate requests; injects security properties.
`src/test/java/com/xpeho/spring_boot_java_random_user/config/SecurityConfigTest.java`	Adds unit tests for security helper methods and in-memory user roles.
`src/test/java/com/xpeho/spring_boot_java_random_user/config/SecurityConfigurationExceptionTest.java`	Adds unit test for the new exception.
`.github/workflows/tests.yaml`	Modifies how `application-test.properties` is prepared in CI.
`.github/workflows/sonar.yaml`	Same CI test-properties preparation change for Sonar job.
`README.md`	Documents security env vars and Basic Auth usage/roles.
`.env.template`	Adds placeholders for the new Spring Security env vars.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

MayuriXx

A corriger le commentaire de copilot et c'est bon pour moi ☺️

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…es and credentials Co-authored-by: Copilot <copilot@github.com>

…operties Co-authored-by: Copilot <copilot@github.com>

…n handling Co-authored-by: Copilot <copilot@github.com>

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

src/test/java/feature/SpringIntegrationTest.java:74

executePut is still using the unauthenticated restTemplate, unlike the GET/POST/DELETE helpers above. Since PUT /random-users/** now requires the ADMIN role, the Cucumber update scenarios that call this helper will start receiving 401/403 instead of exercising the update path.

    protected void executePut(String path, Object payload) {
        String url = "http://localhost:" + port + path;
        HttpHeaders headers = new HttpHeaders();
        headers.setContentType(MediaType.APPLICATION_JSON);
        HttpEntity<Object> request = new HttpEntity<>(payload, headers);
        latestResponse = restTemplate.exchange(url, HttpMethod.PUT, request, String.class);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sonarqube-xpeho · 2026-05-04T09:11:12Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Copilot

Pull request overview

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 spring.sql.init.mode=never
 spring.docker.compose.enabled=false
+logging.level.com.xpeho.spring_boot_java_random_user.presentation.handlers=OFF
+logging.level.com.zaxxer.hikari.pool.PoolBase=ERROR


+            printf '%s' "${{ secrets.APPLICATION_TEST_PROPERTIES }}" | base64 -d >> src/test/resources/application-test.properties
+          fi
          echo "spring.sql.init.mode=never" >> src/test/resources/application-test.properties


-          mkdir -p src/test/resources
-          echo ${{ secrets.APPLICATION_TEST_PROPERTIES }} | base64 -d > src/test/resources/application-test.properties
+          if [ -n "${{ secrets.APPLICATION_TEST_PROPERTIES }}" ]; then
+            printf '%s' "${{ secrets.APPLICATION_TEST_PROPERTIES }}" | base64 -d >> src/test/resources/application-test.properties


+                            .requestMatchers(HttpMethod.GET, RANDOM_USERS_PATH).hasAnyRole(ADMIN_ROLE, "USER", "TEST")
+                            .requestMatchers(HttpMethod.POST, RANDOM_USERS_PATH).hasRole(ADMIN_ROLE)
+                            .requestMatchers(HttpMethod.PUT, RANDOM_USERS_PATH).hasRole(ADMIN_ROLE)
+                            .requestMatchers(HttpMethod.DELETE, RANDOM_USERS_PATH).hasRole(ADMIN_ROLE)


github-advanced-security AI found potential problems Apr 23, 2026

View reviewed changes

Comment thread src/main/java/com/xpeho/spring_boot_java_random_user/config/SecurityConfig.java Fixed

Theo-lbg force-pushed the feat/springSecurity branch from 17b3669 to 3ca0012 Compare April 24, 2026 09:58

Theo-lbg linked an issue Apr 24, 2026 that may be closed by this pull request

Add Spring security #68

Closed

Theo-lbg force-pushed the feat/springSecurity branch 4 times, most recently from 7ca2ec9 to e775d93 Compare April 24, 2026 11:48

Theo-lbg marked this pull request as ready for review April 24, 2026 11:52

Copilot AI review requested due to automatic review settings April 24, 2026 11:52

Copilot started reviewing on behalf of Theo-lbg April 24, 2026 11:53 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

Theo-lbg force-pushed the feat/springSecurity branch from e775d93 to 708523e Compare April 24, 2026 12:08

Copilot AI review requested due to automatic review settings April 24, 2026 12:27

Theo-lbg force-pushed the feat/springSecurity branch from 708523e to 5d30f44 Compare April 24, 2026 12:27

Copilot started reviewing on behalf of Theo-lbg April 24, 2026 12:27 View session

Copilot AI reviewed Apr 24, 2026

MayuriXx reviewed Apr 27, 2026

View reviewed changes

Theo-lbg force-pushed the feat/springSecurity branch from 5d30f44 to 0058607 Compare April 27, 2026 12:12

Copilot AI review requested due to automatic review settings April 27, 2026 13:06

Theo-lbg force-pushed the feat/springSecurity branch from 0058607 to b499879 Compare April 27, 2026 13:06

Copilot started reviewing on behalf of Theo-lbg April 27, 2026 13:06 View session

Copilot AI reviewed Apr 27, 2026

View reviewed changes

MayuriXx reviewed Apr 27, 2026

View reviewed changes

Comment thread .github/workflows/sonar.yaml Outdated

Theo-lbg force-pushed the feat/springSecurity branch from b499879 to e9b3b14 Compare April 27, 2026 14:10

Theo-lbg and others added 4 commits April 29, 2026 10:51

feat(springSecurity): add spring security in app

1df5da2

feat(security): enhance security configuration with multiple user rol…

339e7ee

…es and credentials Co-authored-by: Copilot <copilot@github.com>

feat(test): refactor authentication to use values from application pr…

ea7f383

…operties Co-authored-by: Copilot <copilot@github.com>

feat(security): enhance security filter chain and add custom exceptio…

e856fe6

…n handling Co-authored-by: Copilot <copilot@github.com>

Copilot AI review requested due to automatic review settings April 29, 2026 08:51

MayuriXx force-pushed the feat/springSecurity branch from e9b3b14 to e856fe6 Compare April 29, 2026 08:51

Copilot started reviewing on behalf of MayuriXx April 29, 2026 08:52 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread README.md Outdated

Comment thread .github/workflows/sonar.yaml Outdated

Comment thread src/test/java/com/xpeho/spring_boot_java_random_user/presentation/UserGetByIdContainerTest.java

Comment thread src/test/java/feature/SpringIntegrationTest.java Outdated

MayuriXx force-pushed the feat/springSecurity branch from a401a16 to 293c5eb Compare May 4, 2026 08:43

Copilot AI review requested due to automatic review settings May 4, 2026 08:52

MayuriXx force-pushed the feat/springSecurity branch from 293c5eb to 9b2a10d Compare May 4, 2026 08:52

Copilot started reviewing on behalf of MayuriXx May 4, 2026 08:53 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

feat(springSecurity): add spring security in app

f7bddb9

MayuriXx force-pushed the feat/springSecurity branch from 9b2a10d to f7bddb9 Compare May 4, 2026 08:57

MayuriXx approved these changes May 4, 2026

View reviewed changes

fix(addSpace): space

b80f964

Copilot AI review requested due to automatic review settings May 4, 2026 09:08

MayuriXx approved these changes May 4, 2026

View reviewed changes

Copilot started reviewing on behalf of Theo-lbg May 4, 2026 09:09 View session

MayuriXx merged commit b57bea2 into main May 4, 2026
13 checks passed

MayuriXx deleted the feat/springSecurity branch May 4, 2026 09:09

Copilot AI reviewed May 4, 2026

View reviewed changes

Conversation

Theo-lbg commented Apr 23, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

MayuriXx left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqube-xpeho Bot commented May 4, 2026

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants