Deprecate FormatString for now, escaping of curly braces clashes with token matcher and leads to bad user experience

Author: Florian Kroenert

build.fsx

@@ -35,7 +35,7 @@ let sha = Git.Information.getCurrentHash()
 // version info
 let major = "3"
 let minor = "9"
-let patch = "14"
+let patch = "15"
 
 // Follow SemVer scheme: http://semver.org/
 let asmVersion = major + "." + minor + "." + patch

src/lib/Xrm.Oss.XTL.Interpreter/FunctionHandlers.cs

@@ -1095,32 +1095,6 @@ private static T CheckedCast<T>(object input, string errorMessage, bool failOnEr
             }
         };
 
-        /// <summary>
-        /// Composes multiple values into a format string (like string.Format)
-        /// </summary>
-        public static FunctionHandler FormatString = (primary, service, tracing, interpreterConfig, parameters) =>
-        {
-            if (parameters.Count < 1)
-            {
-                throw new InvalidPluginExecutionException("FormatString needs at least a format string");
-            }
-
-            var format = CheckedCast<string>(parameters[0].Value, "First parameter must be a format string");
-            
-            // Positional parameters only - exactly like C# string.Format
-            var args = parameters.Skip(1).Select(p => p.Value).ToArray();
-            
-            try
-            {
-                var result = string.Format(CultureInfo.InvariantCulture, format, args);
-                return new ValueExpression(result, result);
-            }
-            catch (FormatException ex)
-            {
-                throw new InvalidPluginExecutionException($"Invalid format string: {ex.Message}");
-            }
-        };
-
         private static Entity FetchSnippetByUniqueName(string uniqueName, InterpreterConfig interpreterConfig, IOrganizationService service)
         {
             var tableLogicalName = "oss_xtlsnippet";

src/lib/Xrm.Oss.XTL.Interpreter/XTLInterpreter.cs

@@ -36,7 +36,6 @@ public class XTLInterpreter
             { "Filter", FunctionHandlers.Filter },
             { "First", FunctionHandlers.First },
             { "Format", FunctionHandlers.Format },
-            { "FormatString", FunctionHandlers.FormatString },
             { "GptPrompt", FunctionHandlers.GptPrompt },
             { "If", FunctionHandlers.If },
             { "IndexOf", FunctionHandlers.IndexOf },