Skip to content

Make VaultID conditional on `LoanBrokerSet#497

Open
Tapanito wants to merge 2 commits into
masterfrom
tapanito/lending-optional-vault-id
Open

Make VaultID conditional on `LoanBrokerSet#497
Tapanito wants to merge 2 commits into
masterfrom
tapanito/lending-optional-vault-id

Conversation

@Tapanito
Copy link
Copy Markdown
Collaborator

@Tapanito Tapanito commented Mar 11, 2026

High Level Overview of Change

LoanBrokerSet is a dual-purpose transaction — it creates a new LoanBroker when LoanBrokerID is absent, and modifies an existing one when LoanBrokerID is present. Previously VaultID was marked as Required unconditionally, but VaultID is meaningless (and potentially confusing) on update because the Vault association is fixed at creation time and cannot be changed.

  • VaultID is required when creating a new LoanBroker (LoanBrokerID absent)
  • VaultID must not be present when modifying an existing LoanBroker (LoanBrokerID present) — temINVALID if it is

Context of Change

Type of Change

  • New XLS Draft
  • XLS Update (changes to an existing XLS)
  • XLS Status Change (e.g., Draft → Final, Draft → Stagnant)
  • Process/Meta (changes to CONTRIBUTING.md, XLS-1, templates, etc.)
  • Infrastructure (CI, workflows, scripts, website)
  • Documentation (README updates, typo fixes)

@Tapanito Tapanito requested a review from ximinez March 11, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant