Skip to content

Commit b5ebfe6

Browse files
oleks-ripTapanito
authored andcommitted
fix: Remove superfluous view update from credentials (#6545)
1 parent 92aecf3 commit b5ebfe6

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/libxrpl/tx/transactors/credentials/CredentialCreate.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,14 +146,15 @@ CredentialCreate::doApply()
146146
}
147147
else
148148
{
149+
// Added to both dirs, owned only by issuer. CredentialAccept will transfer ownership to
150+
// subject. CredentialDelete will remove from both dirs and decrement 1 ownerCount.
149151
auto const page =
150152
view().dirInsert(keylet::ownerDir(subject), credentialKey, describeOwnerDir(subject));
151-
JLOG(j_.trace()) << "Adding Credential to owner directory " << to_string(credentialKey.key)
152-
<< ": " << (page ? "success" : "failure");
153+
JLOG(j_.trace()) << "Adding Credential to subject directory "
154+
<< to_string(credentialKey.key) << ": " << (page ? "success" : "failure");
153155
if (!page)
154156
return tecDIR_FULL;
155157
sleCred->setFieldU64(sfSubjectNode, *page);
156-
view().update(view().peek(keylet::account(subject)));
157158
}
158159

159160
view().insert(sleCred);

0 commit comments

Comments
 (0)