Merged
Conversation
Member
Refactor observer to clear removed outbounds instead of updating status. Introduced slices package for improved outbound checking.
Member
|
重新弄了一下这样应该没问题了 很小的改动 |
RPRX
changed the title
Member
|
@Fangliding 修一下 test 然后 force-push 一下吧 |
Fangliding
added a commit
that referenced
this pull request
Apr 6, 2026
* fix: prune stale observatory status * More readable Refactor observer to clear removed outbounds instead of updating status. Introduced slices package for improved outbound checking. --------- Co-authored-by: 风扇滑翔翼 <Fangliding.fshxy@outlook.com>
Member
|
aiya |
Member
|
@Fangliding test 还是没修好， |
Fangliding
added a commit
that referenced
this pull request
Apr 7, 2026
* fix: prune stale observatory status * More readable Refactor observer to clear removed outbounds instead of updating status. Introduced slices package for improved outbound checking. --------- Co-authored-by: 风扇滑翔翼 <Fangliding.fshxy@outlook.com>
Member
|
忘记add了 这次该好了 |
Exclude0122
pushed a commit
to Exclude0122/Xray-core
that referenced
this pull request
Apr 19, 2026
* fix: prune stale observatory status * More readable Refactor observer to clear removed outbounds instead of updating status. Introduced slices package for improved outbound checking. --------- Co-authored-by: 风扇滑翔翼 <Fangliding.fshxy@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prune stale observatory statuses when an outbound is no longer returned by the handler selector.
Problem
observatory.Observer.updateStatus()didn't remove entries for outbounds that had already been removed. As a result,GetObservation()could keep returning staleOutboundStatusitems after outbound removal.Changes
Validation
go test ./app/observatory ./app/observatory/burstHandlerServiceandObservatoryServiceGetOutboundStatus