Skip to content
This repository was archived by the owner on Apr 13, 2020. It is now read-only.

Check collections if database is defined on connection string#98

Open
tiagor87 wants to merge 3 commits into
Xabaril:masterfrom
tiagor87:feature/database_collection_check
Open

Check collections if database is defined on connection string#98
tiagor87 wants to merge 3 commits into
Xabaril:masterfrom
tiagor87:feature/database_collection_check

Conversation

@tiagor87

Copy link
Copy Markdown

My server has restrictions, where I can only check collections in an allowed database. List databases always fails.

@GustavoFonsecaDeAlmeida

Copy link
Copy Markdown
Contributor

@unaizorrilla @CarlosLanderas Please can verify ? i work with @tiagor87 and had a same problem with mongodb.

@unaizorrilla unaizorrilla left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi you need to fix some items in the review and also:

  • Please upgrade package version on dependencies.props for mongodb

Comment thread src/BeatPulse.MongoDb/MongoDbLiveness.cs
@unaizorrilla

Copy link
Copy Markdown
Collaborator

Hi @tiagor87 @GustavoFonsecaDeAlmeida

submmited review, this feature is already include in new AspNetCore.HealthChecks

@GustavoFonsecaDeAlmeida

Copy link
Copy Markdown
Contributor

@unaizorrilla @CarlosLanderas can merge this changes?

@tiagor87

Copy link
Copy Markdown
Author

@unaizorrilla @CarlosLanderas Please, can you merge this changes asap?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants