Skip to content

Improve License file.#40

Closed
polarisfm wants to merge 4 commits into
XboxDev:masterfrom
polarisfm:master
Closed

Improve License file.#40
polarisfm wants to merge 4 commits into
XboxDev:masterfrom
polarisfm:master

Conversation

@polarisfm

Copy link
Copy Markdown

Remove the somewhat rambly LICENSE.txt in favor of a LICENSE file that simply contains the same modified BSD 3-clause license and more up-to-date copyright attribution.

@GXTX

GXTX commented Jul 2, 2020

Copy link
Copy Markdown
Contributor

I have no thoughts on this but since you are changing something that gets included in the CI stuff can you also change it in .github/workflows/CI.yml, should be 3 lines to change. Would probably also be a good idea to change it in extract-xiso.c as well where it's much more rambly and includes a weird changelog.

LICENSE.TXT -> LICENSE

@JayFoxRox

Copy link
Copy Markdown
Member

nit: Please remove trailing period from the commit messages for consistency with our git log.

Ideally squash commits and just call it something like "Cleanup license file"

@polarisfm polarisfm closed this Jul 2, 2020
@JayFoxRox

Copy link
Copy Markdown
Member

Replaced by #41 (Reason: user is inexperienced with GitHub and probably didn't know that you can force-push to existing PRs; maybe also accidentally deleted their repository or branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants