Fixed ENUMs where empty string is returned

This was causing NPE due to missing enum .
TaxType should not be an enum as this list varies from org to org when you create custom tax rates.  Change type to String

Author: SidneyAllen

README.md

@@ -74,7 +74,7 @@ Add the dependency to your pom.xml.  Gradle, sbt and other build tools can be fo
     <dependency>
       <groupId>com.github.xeroapi</groupId>
       <artifactId>xero-java</artifactId>
-      <version>2.2.3</version>
+      <version>2.2.4</version>
 	</dependency>
 
 

pom.xml

@@ -4,7 +4,7 @@
 	<groupId>com.github.xeroapi</groupId>
 	<artifactId>xero-java</artifactId>
 	<packaging>jar</packaging>
-	<version>2.2.2</version>
+	<version>2.2.4</version>
 	<name>Xero-Java SDK</name>
 	<description>This is the official Java SDK for Xero API</description>
 	<url>https://github.com/XeroAPI/Xero-Java</url>

src/main/java/com/xero/api/JsonConfig.java

@@ -132,7 +132,7 @@ public String getAccessTokenUrl() {
 
   @Override
   public String getUserAgent() {
-    return USER_AGENT + " " + CONSUMER_KEY + " [Xero-Java-2.2.3]";
+    return USER_AGENT + " " + CONSUMER_KEY + " [Xero-Java-2.2.4]";
   }
 
   @Override

src/main/java/com/xero/models/accounting/Account.java

@@ -180,7 +180,9 @@ public enum BankAccountTypeEnum {
 
     CREDITCARD("CREDITCARD"),
 
-    PAYPAL("PAYPAL");
+    PAYPAL("PAYPAL"),
+    
+    EMPTY("");
 
     private String value;
 
@@ -302,7 +304,9 @@ public enum SystemAccountEnum {
 
     UNREALISEDCURRENCYGAIN("UNREALISEDCURRENCYGAIN"),
 
-    WAGEPAYABLES("WAGEPAYABLES");
+    WAGEPAYABLES("WAGEPAYABLES"),
+    
+    EMPTY("");
 
     private String value;
 

src/main/java/com/xero/models/accounting/TaxRate.java

@@ -19,7 +19,6 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonValue;
 import com.xero.models.accounting.TaxComponent;
-import com.xero.models.accounting.TaxType;
 import io.swagger.annotations.ApiModel;
 import io.swagger.annotations.ApiModelProperty;
 import java.util.ArrayList;
@@ -38,7 +37,7 @@ public class TaxRate {
 
 
   @JsonProperty("TaxType")
-  private TaxType taxType = null;
+  private String taxType = null;
 
 
   @JsonProperty("TaxComponents")
@@ -198,21 +197,21 @@ public void setName(String name) {
     this.name = name;
   }
 
-  public TaxRate taxType(TaxType taxType) {
+  public TaxRate taxType(String taxType) {
     this.taxType = taxType;
     return this;
   }
 
    /**
-   * Get taxType
+   * The tax type
    * @return taxType
   **/
-  @ApiModelProperty(value = "")
-  public TaxType getTaxType() {
+  @ApiModelProperty(value = "The tax type")
+  public String getTaxType() {
     return taxType;
   }
 
-  public void setTaxType(TaxType taxType) {
+  public void setTaxType(String taxType) {
     this.taxType = taxType;
   }