NZP-5516 Update tests to remove usage of deprecated NZ API fields#426
Merged
Merged
Conversation
| assertThat(response.getLeaveType().getLeaveTypeID(), is(equalTo(UUID.fromString("35da97ae-05b9-427f-9a98-69157ba42cec")))); | ||
| assertThat(response.getLeaveType().getScheduleOfAccrual(), is(equalTo(com.xero.models.payrollnz.EmployeeLeaveType.ScheduleOfAccrualEnum.ANNUALLYAFTER6MONTHS))); | ||
| assertThat(response.getLeaveType().getHoursAccruedAnnually(), is(equalTo(10.0))); | ||
| assertThat(response.getLeaveType().getUnitsAccruedAnnually(), is(equalTo(0.0))); |
Contributor
Author
There was a problem hiding this comment.
Author: the unitsAccruedAnnually has a value of 0 in the sdk, hence the value update
https://github.com/XeroAPI/Xero-OpenAPI/blob/b12343a7010ef138f893b1ae28662875db276cea/xero-payroll-nz.yaml#L1828
pj-jacobs
approved these changes
Nov 20, 2025
the-chris-mitchell
force-pushed
the
NZP-5516
branch
2 times, most recently
from
November 25, 2025 02:04
64781e8 to
8c69786
Compare
the-chris-mitchell
force-pushed
the
NZP-5516
branch
from
November 25, 2025 20:52
8c69786 to
eb94ee7
Compare
the-chris-mitchell
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows this PR against the open api spec to build
XeroAPI/Xero-OpenAPI#779