remove invalid type: string from Contact property in Quote schema#749
Merged
the-chris-mitchell merged 2 commits intoXeroAPI:masterfrom Oct 29, 2025
Merged
Conversation
|
PETOSS-819 |
|
Thanks for raising an issue, a ticket has been created to track your request |
the-chris-mitchell
approved these changes
Oct 29, 2025
Contributor
|
Thanks for your contribution @luke-wriglesworth, I will bundle this in the next release. |
|
🎉 This PR is included in version 9.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 9.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 9.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed an incorrect
type: stringdeclaration from theContactproperty in theQuoteschema. TheContactproperty already uses$refto reference theContactschema, so having an additionaltype: stringdeclaration is invalid OpenAPI syntax.This can cause code generation tools to incorrectly interpret the
Contactproperty. For example, the current version ofopenapi-generator-cligenerates theContactproperty ofQuoteas a string.Release Notes
This change fixes a mistake in the
Quoteschema where theContactproperty had both a$refand atype: stringsibling. The change ensures compliance with the OpenAPI specification and prevents issues with code generators.Screenshots (if appropriate):
Types of Changes