fix: fallback to V2 granular scopes on 401/403 as well as invalid_scope#177
Open
ErnestHysa wants to merge 2 commits into
Open
fix: fallback to V2 granular scopes on 401/403 as well as invalid_scope#177ErnestHysa wants to merge 2 commits into
ErnestHysa wants to merge 2 commits into
Conversation
Previously the xero-client only fell back from V1 to V2 scopes on an 'invalid_scope' (400) error. New Custom Connections created after the April 2025 deprecation of accounting.transactions return 401 or 403 instead of 400, causing them to fail without this fix. Closes XeroAPI#175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
New Custom Connections created after the April 2025 deprecation of
accounting.transactionsfail authentication because the server returns 401 or 403 instead of 400invalid_scope.The xero-client only falls back from V1 (deprecated
accounting.transactions) to V2 (granular) scopes on aninvalid_scopeerror, but new connections using deprecated V1 scopes receive 401/403 instead.Fix
Extend the V1→V2 fallback condition to also trigger on 401 and 403 responses, not just on 400
invalid_scope.Closes #175