PHP Deprecated: Implicitly marking parameter $data as nullable is deprecated, PHP 8.4

[Xon]

SDK you're using (please complete the following information):
2.23.3

Describe the bug
https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

To Reproduce
Using php 8.4-dev, and most xero-php-oauth2 objects will trigger deprecation warnings

Expected behavior
No deprecation warnings

[github-actions]

PETOSS-407

[github-actions]

Thanks for raising an issue, a ticket has been created to track your request

[geoidesic]

Dear Xero - are you listening? This issue was raised in March. Is anyone monitoring this channel?

[wallacio]

So this exists all the way up to current SDK version 9.x?

Creation of dynamic property XeroAPI\XeroPHP\JWTClaims::$accessToken is deprecated

This should be a straightforward fix to this particular class at least. Can we have a progress update please? Are we accepting pull requests, or just ignoring?

[willpower232]

they're using the openapi generator but not using php-nextgen so it has this problem, this means it can't be fixed by pull request unless the whole library is regenerated

I don't think they've published exactly how they're using the generator for each language so there isn't much we can do other than shout and hope they eventually use php-nextgen next time they generate the library

[cseufert]

So it looks like the v10.0 release did nothing to address this issue.

[willpower232]

there are a few clues in #394 but not sure if @sangeet-joy-tw can find a way to change the generator

[dereuromark]

Deprecated: XeroAPI\XeroPHP\Models\Accounting\ValidationError::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/vendor/xeroapi/xero-php-oauth2/lib/Models/Accounting/ValidationError.php on line 179

Any update on this one?

[cs278]

The generator was fixed in OpenAPITools/openapi-generator#20243 and released a while back.

they're using the openapi generator but not using php-nextgen so it has this problem,

From what I can tell the standard php generator was fixed so switching to php-nextgen is not required.

[willpower232]

ah good to know, then its the classic "whoever generates the library has to update their version of the generator", definitely hit that a few times with it myself 😅

[GraemeBrett]

Still an issue in PHP 8.5 almost 2 years later

[beeradmoore]

@the-chris-mitchell , is it possible to get some eyes on this issue and any info as to what is coming soon?

Comments above seem to indicate it is fixed upstream, but I don't understand how OpenAPITools/openapi-generator relates to this repository and how it works together and if that is a matter of running a deploy script again.

We are already using 10.4.0.x-dev to fix firebase/php-jwt issue. Though I could have sworn I saw a 10.4.1.x-dev at some point.

Would the php84 (and ideally php85 if there were any) issues that are fixed be part of the upcoming v10.4.1 release? Our current workaround is to continue to use 10.4.0.x-dev and suppress the warnings whenever we use xero-php-oauth2 while we wait for new versions.

[beeradmoore]

Update: 10.4.0.x-dev has been deleted and has broken us being able to update any composer packages that are unrelated to Xero. Can you not delete package versions in the future and just add new ones?

It was ~5 minutes between I saw this

  - Downgrading xeroapi/xero-php-oauth2 (10.4.1.x-dev 93f61e2 => 10.4.0.x-dev d568f1b): Extracting archive

and then another dev on my team telling me "Hey, I can't do anything because xero-php-oauth2 10.4.0.x-dev doesn't exist."

[the-chris-mitchell]

Hey @beeradmoore can you please try the dev-master version to fix your immediate issue? I'll get back to you soon with a full response.