fix(tui): remove duplicate image paste on Windows/WSL right-click#1721
Open
NikoDi2000 wants to merge 1 commit into
Open
fix(tui): remove duplicate image paste on Windows/WSL right-click#1721NikoDi2000 wants to merge 1 commit into
NikoDi2000 wants to merge 1 commit into
Conversation
Remove promptRef.current?.paste() from onMouseDown handler. This call duplicated the terminal's own bracketed paste mechanism, causing images to be pasted twice on Windows/WSL. Fixes XiaomiMiMo#1720
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.tsx中onMouseDown的promptRef.current?.paste()调用Root Cause
MiMoCode fork 时在
onMouseDown中新增了promptRef.current?.paste()，上游 opencode 没有这个调用。在 Windows Terminal 中，右键会同时触发：onPaste→pasteFromClipboard()onMouseDown→promptRef.current?.paste()→pasteFromClipboard()文本粘贴不受影响，因为
onPaste直接拿到文本内容处理，不走pasteFromClipboard()。Test
Fixes #1720