fix: Remove boost system dependencies #9492
Open
X-Ryl669 wants to merge 1 commit intoXilinx:masterfrom
Open
Conversation
X-Ryl669
requested review from
AShivangi,
chvamshi-xilinx and
rozumx
as code owners
…him that was removed in newer boost packaging Signed-off-by: X-Ryl669 <boite.pour.spam@gmail.com>
X-Ryl669
force-pushed
the
fix-arch-build
branch
from
75a63b8 to
0b9e245
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it's a deprecated empty shim that was removed in newer boost packaging.
Problem solved by the commit
Current master doesn't build on Arch linux and latest kernel because of the Boost System dependency package in CMake.
Boost system is an empty package, there's no sources or headers in it and it's only present for a small period so it doesn't break legacy code depending on it. Many rolling release distributions have removed it so it doesn't build if you rely on it.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
I haven't created an issue for it, but will do if required.
How problem was solved, alternative solutions (if any) and why they were rejected
I've remove the dependency since it was useless anyway.
Risks (if any) associated the changes in the commit
On very very old system, where Boost System was not empty, this could break. However, it's unlikely such system would build the current driver due to their aging kernel.
What has been tested and how, request additional testing if necessary
It fixes a build issue, no actual code was modified, so it's unlikely to break the driver features
Documentation impact (if any)