Skip to content

AIESW-28056: [XRT-SMI] Add preemption counters to aie partitions report #9762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stsoe merged 1 commit into from
May 6, 2026
+16 −10
Merged

AIESW-28056: [XRT-SMI] Add preemption counters to aie partitions report #9762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/runtime_src/core/common/query_requests.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1817,6 +1817,8 @@ struct aie_partition_info : request
uint64_t command_completions = 0;
uint64_t migrations = 0;
uint64_t preemptions = 0;
uint64_t preemption_frame_event = 0;
Copy link
Copy Markdown

@vincech-amd vincech-amd May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remove "preemptions"?

Copy link
Copy Markdown
Collaborator Author

@dkotipal-xilinx dkotipal-xilinx May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s currently kept for backward compatibility, but we can consider removing in another PR

uint64_t preemption_layer_event = 0;
uint64_t errors = 0;
uint64_t pasid = 0;
qos_info qos {};
Expand Down
24 changes: 14 additions & 10 deletions src/runtime_src/core/tools/common/reports/ReportAiePartitions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ populate_aie_partition(const xrt_core::device* device)
pt_entry.put("command_submissions", entry.command_submissions);
pt_entry.put("command_completions", entry.command_completions);
pt_entry.put("migrations", entry.migrations);
pt_entry.put("preemption_frame_event", entry.preemption_frame_event);
pt_entry.put("preemption_layer_event", entry.preemption_layer_event);
pt_entry.put("errors", entry.errors);
pt_entry.put("suspensions", entry.suspensions);
pt_entry.put("memory_usage", entry.memory_usage == 0 ? "N/A" : xrt_core::utils::unit_convert(entry.memory_usage));
Expand Down Expand Up @@ -127,11 +129,11 @@ writeReport(const xrt_core::device* /*_pDevice*/,
_output << " HW Contexts:\n";

const std::vector<std::string> headers = {
" |PID |Ctx ID |Submissions |Migrations |Err |Priority |",
" |Process Name |Status |Completions |Suspensions | |GOPS |",
" |Memory Usage |Instr BO | | | |FPS |",
" | | | | | |Latency |",
" |====================|===========|============|============|=====|=========|"
" |PID |Ctx ID |Submissions |Migrations |Frame Evts |Err |Priority |",
" |Process Name |Status |Completions |Suspensions |Layer Evts | |GOPS |",
" |Memory Usage |Instr BO | | | | |FPS |",
" | | | | | | |Latency |",
" |====================|===========|============|============|============|=====|=========|"
};

for (const auto& header : headers) {
Expand All @@ -143,30 +145,32 @@ writeReport(const xrt_core::device* /*_pDevice*/,
const auto& hw_context = pt_hw_context.second;

std::vector<boost::format> row_data;
row_data.emplace_back(boost::format(" |%-20s|%-11s|%-12s|%-12s|%-5s|%-9s|")
row_data.emplace_back(boost::format(" |%-20s|%-11s|%-12s|%-12s|%-12s|%-5s|%-9s|")
% hw_context.get<int>("pid")
% hw_context.get<std::string>("context_id")
% hw_context.get<uint64_t>("command_submissions")
% hw_context.get<uint64_t>("migrations")
% hw_context.get<uint64_t>("preemption_frame_event")
% hw_context.get<uint64_t>("errors")
% hw_context.get<std::string>("priority"));

row_data.emplace_back(boost::format(" |%-20s|%-11s|%-12s|%-12s| |%-9s|")
row_data.emplace_back(boost::format(" |%-20s|%-11s|%-12s|%-12s|%-12s| |%-9s|")
% hw_context.get<std::string>("process_name")
% hw_context.get<std::string>("status")
% hw_context.get<uint64_t>("command_completions")
% hw_context.get<uint64_t>("suspensions")
% hw_context.get<uint64_t>("preemption_layer_event")
% hw_context.get<std::string>("gops"));

row_data.emplace_back(boost::format(" |%-20s|%-11s| | | |%-9s|")
row_data.emplace_back(boost::format(" |%-20s|%-11s| | | | |%-9s|")
% hw_context.get<std::string>("memory_usage")
% hw_context.get<std::string>("instr_bo_mem")
% hw_context.get<std::string>("fps"));

row_data.emplace_back(boost::format(" | | | | | |%-9s|")
row_data.emplace_back(boost::format(" | | | | | | |%-9s|")
% hw_context.get<std::string>("latency"));

row_data.emplace_back(boost::format(" |--------------------|-----------|------------|------------|-----|---------|"));
row_data.emplace_back(boost::format(" |--------------------|-----------|------------|------------|------------|-----|---------|"));
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: unnecessary temporary object created while calling emplace_back [hicpp-use-emplace]

Suggested change
row_data.emplace_back(boost::format(" |--------------------|-----------|------------|------------|------------|-----|---------|"));
row_data.emplace_back(" |--------------------|-----------|------------|------------|------------|-----|---------|");


for (const auto& row : row_data) {
_output << row << "\n";
Expand Down
Loading