[AIESW-23180] Duplicate onnx.DequantizeLinear if it has multiple consumers while removing binary op#527
Open
tanzeel-amd wants to merge 2 commits into
Open
[AIESW-23180] Duplicate onnx.DequantizeLinear if it has multiple consumers while removing binary op#527tanzeel-amd wants to merge 2 commits into
tanzeel-amd wants to merge 2 commits into
Conversation
…ore updating the scale, so only the binary operation path uses the new scale while other users remain unchanged
tanzeel-amd
changed the title
tanzeel-amd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: When a dequantize node feeds multiple operations (e.g., Sigmoid and Mul), folding a binary operation into it updated the scale for all users, causing incorrect results.
Fix: Detect when a dequantize node has multiple users and duplicate it before updating the scale, so only the binary operation path uses the new scale while other users remain unchanged.
Impact: Ensures correctness when optimizing quantized models with shared dequantize nodes, preventing incorrect quantization scale propagation.