Skip to content

Adding the Remove Binary pass to XMC passes#664

Open
pragyam32 wants to merge 5 commits into
Xilinx:feature/onnx-to-tosafrom
pragyam32:pragya.RemoveBinary
Open

Adding the Remove Binary pass to XMC passes#664
pragyam32 wants to merge 5 commits into
Xilinx:feature/onnx-to-tosafrom
pragyam32:pragya.RemoveBinary

Conversation

@pragyam32
Copy link
Copy Markdown

@pragyam32 pragyam32 commented Apr 6, 2026

  • Added the base pass from DMAC , with q/Dq
  • Added new pattern without Q
  • Added new pattern without DQ

Needed for CVML models , scene_detection

@pragyam32 pragyam32 force-pushed the pragya.RemoveBinary branch from b11713f to 9a0eb70 Compare April 7, 2026 15:47
@pragyam32 pragyam32 marked this pull request as ready for review April 7, 2026 15:47
@sambanerxilinxamd sambanerxilinxamd self-requested a review April 8, 2026 08:38
Comment thread src/Dialect/ONNX/Transforms/xmc/DQBinaryQOptPass.cpp
Copy link
Copy Markdown

@sambanerxilinxamd sambanerxilinxamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks ok except the rounding.

@pragyam32 pragyam32 force-pushed the pragya.RemoveBinary branch 2 times, most recently from e517ec7 to fa654eb Compare April 10, 2026 11:44
@jorickert jorickert removed their request for review April 10, 2026 12:12
@pragyam32 pragyam32 force-pushed the pragya.RemoveBinary branch from 1789e22 to 19548a6 Compare April 10, 2026 20:56
…a.RemoveBinary

# Conflicts:
#	src/Dialect/ONNX/Transforms/CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants