chore(genesis): update genesis files#2354
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gzliudan
requested review from
AnilChinchawale,
anunay-xin,
benjamin202410,
liam-lai and
wanwiset25
anunay-xin
approved these changes
May 25, 2026
gzliudan
force-pushed
the
new-genesis-file
branch
2 times, most recently
from
3c77724 to
9db5fc8
Compare
liam-icheng-lai
approved these changes
Jun 2, 2026
gzliudan
force-pushed
the
new-genesis-file
branch
2 times, most recently
from
3cf207e to
20e4872
Compare
wanwiset25
approved these changes
Jun 15, 2026
gzliudan
force-pushed
the
new-genesis-file
branch
from
20e4872 to
622e1ce
Compare
benjamin202410
approved these changes
Jun 16, 2026
gzliudan
force-pushed
the
new-genesis-file
branch
from
622e1ce to
31307d2
Compare
gzliudan
force-pushed
the
new-genesis-file
branch
3 times, most recently
from
6363ef4 to
2652e9b
Compare
There was a problem hiding this comment.
Pull request overview
This PR refreshes the embedded network genesis JSON files (mainnet/testnet/devnet) to match the post-#2329 chain config schema, adding explicit fork switch fields, system contract addresses, and XDPoS v2 configuration sections.
Changes:
- Expanded
configsections for mainnet/testnet with TIP/fork blocks, Cancun, and system-contract address fields, plus XDPoS v2 config payloads. - Updated devnet genesis to include the newer fork fields and corrected legacy XDPoS JSON keys/typos (e.g.,
foundationWalletAddr,switchEpoch,expTimeoutConfig.base). - Added/extended XDPoS v2
allConfigsentries in genesis files.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| genesis/mainnet.json | Adds explicit fork/TIP switches, system-contract addresses, and XDPoS v2 config structure for mainnet. |
| genesis/testnet.json | Adds explicit fork/TIP switches, system-contract addresses, and XDPoS v2 config structure for testnet. |
| genesis/devnet.json | Adds fork/TIP switches and XDPoS v2 config structure; also corrects several legacy key issues, but currently diverges from built-in devnet presets. |
gzliudan
force-pushed
the
new-genesis-file
branch
from
2652e9b to
f8b2b70
Compare
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jul 6, 2026
…is hash The devnet genesis hash exposed by `XDC init devnet` diverged from params.DevnetGenesisHash (used by `XDC --devnet` / DefaultDevnetGenesisBlock). The two paths would have produced different block 0, making nodes initialized via each method unable to peer with one another. Root cause ---------- Commit 00be1f5 (chore(devnet): may 2026 devnet reset, XinFinOrg#2347, 2026-05-25) updated core/genesis_alloc_devnet.go and common/constants.devnet.go as part of a devnet network reset. It added three pre-funded accounts to DevnetAllocData: 4b1a14a10cb48e4cfddd17c379dfcaa358b011bc d16c20329d391104029d0a850dcdf9ed6e259b60 cc08002e7e4baec892785887a74d35557e8d2c15 params.DevnetGenesisHash was later updated to reflect the new state root in dfce638 (XinFinOrg#2329, 2026-05-28). genesis/devnet.json was NOT touched by either commit; its alloc still contained only the pre-May-2026 eight accounts. Commit 1c0923d (XinFinOrg#2354, 2026-07-06) then filled in the config section of devnet.json but again left the alloc unchanged, so the JSON-derived genesis hash remained 0x7dad95... while params.DevnetGenesisHash was 0xb8be00... Fix --- Add the three missing balance-only accounts to genesis/devnet.json alloc, bringing it into parity with DevnetAllocData. After this change: json.Unmarshal(DevnetGenesis).ToBlock().Hash() == params.DevnetGenesisHash == 0xb8be003946a9c268... Verified by running TestEmbeddedGenesisConfigMatchesParams (all three networks pass) and a targeted hash-equality check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
update genesis files for mainnet/testnet/devnet after PR #2329
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that