Skip to content

feat(ci): before devnet deployment, pull and apply start script from Xinfin-Node to configmap#2361

Merged
wanwiset25 merged 2 commits into
dev-upgradefrom
ci-apply-start-script
Jul 3, 2026
Merged

feat(ci): before devnet deployment, pull and apply start script from Xinfin-Node to configmap#2361
wanwiset25 merged 2 commits into
dev-upgradefrom
ci-apply-start-script

Conversation

@wanwiset25

Copy link
Copy Markdown
Collaborator

Proposed changes

Before devnet deployment, pull and apply start script from Xinfin-Node to configmap.
Remove redundant start-scripts inside XDPoSChain repo

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 177291d9-3411-47b1-8529-bd0d333c0e5d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-apply-start-script

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wanwiset25 wanwiset25 force-pushed the ci-apply-start-script branch from 50aca80 to e5445f2 Compare May 29, 2026 09:46
Comment thread .github/workflows/ci.yml
Revert "remove redundant start-scripts (use injection from Xinfin-Node repo)"

This reverts commit 50aca80.

remove redundant start-scripts (use injection from Xinfin-Node repo)
@wanwiset25 wanwiset25 force-pushed the ci-apply-start-script branch from e5445f2 to c69d579 Compare July 3, 2026 04:54
@wanwiset25 wanwiset25 merged commit 42c4af1 into dev-upgrade Jul 3, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants