update modulbuilder itself

Author: ggoffy

admin/building.php

@@ -38,7 +38,7 @@
 
 $cachePath = \XOOPS_VAR_PATH . '/caches/modulebuilder_cache_';
 if (!\is_dir($cachePath)) {
-    if (!\mkdir($cachePath, 0777) && !\is_dir($cachePath)) {
+    if (!\mkdir($cachePath) && !\is_dir($cachePath)) {
         throw new \RuntimeException(\sprintf('Directory "%s" was not created', $cachePath));
     }
     \chmod($cachePath, 0777);

admin/devtools.php

@@ -85,8 +85,8 @@
         $regexFiles = new RegexIterator($Iterator, '/^.+\.(php|tpl)$/i', RecursiveRegexIterator::GET_MATCH);
         //$files = new RegexIterator($flattened, '#^(?:[A-Z]:)?(?:/(?!\.Trash)[^/]+)+/[^/]+\.(?:php|html)$#Di');
         $modfiles = [];
-        foreach ($regexFiles as $regexFiles) {
-            $file = str_replace('\\', '/', $regexFiles[0]);
+        foreach ($regexFiles as $regexFile) {
+            $file = str_replace('\\', '/', $regexFile[0]);
             if (!\in_array($file, $langfiles)) {
                 $modfiles[] = $file;
             }

admin/fields.php

@@ -209,7 +209,7 @@
                 if ($order > 0) {
                     $fieldOrder = $fieldsObj->get($order);
                     $fieldOrder->setVar('field_order', $i);
-                    if (!$fieldsObj->insert($fieldOrder)) {
+                    if (!$fieldsObj->insert()) {
                         $error = true;
                     }
                     ++$i;

admin/logo.php

@@ -35,7 +35,7 @@
 /**
  * @param string $val
  */
-function phpFunction($val = ''): void
+function phpFunction(string $val = ''): void
 {
     // create php function here
     echo $val;

admin/modules.php

@@ -167,7 +167,7 @@
                 'mod_subversion'     => Request::getString('mod_subversion', '', 'POST'),
             ]
         );
-        $moduleOption = Request::getArray('module_option', []);
+        $moduleOption = Request::getArray('module_option');
         $modulesObj->setVar('mod_admin', \in_array('admin', $moduleOption));
         $modulesObj->setVar('mod_user', \in_array('user', $moduleOption));
         $modulesObj->setVar('mod_blocks', \in_array('blocks', $moduleOption));

admin/settings.php

@@ -123,7 +123,7 @@
                 'set_subversion'     => \Xmf\Request::getString('set_subversion', '', 'POST'),
             ]
         );
-        $settingOption = \Xmf\Request::getArray('setting_option', []);
+        $settingOption = \Xmf\Request::getArray('setting_option');
         $settingsObj->setVar('set_admin', \in_array('admin', $settingOption));
         $settingsObj->setVar('set_user', \in_array('user', $settingOption));
         $settingsObj->setVar('set_blocks', \in_array('blocks', $settingOption));

admin/tables.php

@@ -163,7 +163,7 @@
         }
         $tablesObj->setVar('table_autoincrement', (1 == $_REQUEST['table_autoincrement']) ? 1 : 0);
         // Options
-        $tableOption = \Xmf\Request::getArray('table_option', []);
+        $tableOption = \Xmf\Request::getArray('table_option');
         $tablesObj->setVar('table_install', \in_array('install', $tableOption));
         $tablesObj->setVar('table_index', \in_array('index', $tableOption));
         $tablesObj->setVar('table_blocks', \in_array('blocks', $tableOption));
@@ -245,7 +245,7 @@
                 if ($order > 0) {
                     $tableOrder = $tablesObj->get($order);
                     $tableOrder->setVar('table_order', $i);
-                    if (!$tablesObj->insert($tableOrder)) {
+                    if (!$tablesObj->insert()) {
                         $error = true;
                     }
                     ++$i;

assets/css/admin/style.css

@@ -183,6 +183,7 @@ img.imageToggle {
 .portlet {
     margin: 0 0.1em 1em 0;
     padding: 0 0.3em;
+    min-width: 250px;
 }
 
 .portlet-header {

docs/changelog.txt

@@ -1,3 +1,7 @@
+<h5>3.7.1 Alpha [2026-04-05]</h5>  Dev: XOOPS 2.5.11 Stable, PHP 8.0
+ - updated creation code to generate module with no errors from coderabbitai (goffy)
+ - checked modulebuilder code by PHPStorm > Inspect code (goffy)
+
 <h5>3.7.0 RC1   [2024-02-01]</h5>  Dev: XOOPS 2.5.11 Stable, PHP 8.0
  - updated version check for XOOPS 2.5.11 Stable (goffy)
  - moved to singular table names (mamba/goffy)
@@ -15,6 +19,8 @@
  - added field prefix again (goffy)
  - fixed bug in block links (goffy)
  - fixed bug with short text in block (goffy)
+ - changed admin tables default class to outer (goffy)
+ - fixed bug with add stylesheet in admin/header (goffy)
 
 <h5>3.7.0 Alpha   [2023-07-06]</h5>  Dev: XOOPS 2.5.11 RC2, PHP 8.0
  - implemented smarty 3 (zivXP/goffy)

docs/license.txt

@@ -54,7 +54,7 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 POSSIBILITY OF SUCH DAMAGE.
 
 This software was created to be free of defects and is designed to
-function on PC computers only. While this software has been tested 
+function on PC only. While this software has been tested
 and proven to run accurately, in the unlikely event of any user or 
 computer incompatibility issues, the end user assumes complete 
 liability of usage. This software contains no adware, scumware or