update modulbuilder itself - correction 4

Author: ggoffy

admin/tables.php

@@ -245,9 +245,8 @@
             foreach ($_POST['torder'] as $order) {
                 if ($order > 0) {
                     $tablesObj = $tablesHandler->get((int)$order);
-                    $tablesObj->setVar('table_order', $i);
                     if ($tablesObj instanceof \XoopsObject) {
-                        $tablesObj->setVar('field_order', $i);
+                        $tablesObj->setVar('table_order', $i);
                         if (!$tablesHandler->insert($tablesObj)) {
                             $error = true;
                         }

include/update.php

@@ -875,8 +875,9 @@ function modulebuilder_check_db($module)
     $sortElements[] = 'TextVotes';
     $sortElements[] = 'TextReads';
     foreach ($sortElements as $key => $sortElement) {
-        $xoopsDB->query('UPDATE ' . $xoopsDB->prefix('modulebuilder_fieldelements') . ' SET `fieldelement_sort` = ' . ($key + 1) . ' WHERE `' . $xoopsDB->prefix('modulebuilder_fieldelements') . "`.`fieldelement_name` = '" . $sortElement . "'");
-
+        if (!$xoopsDB->query('UPDATE ' . $xoopsDB->prefix('modulebuilder_fieldelements') . ' SET `fieldelement_sort` = ' . ($key + 1) . ' WHERE `' . $xoopsDB->prefix('modulebuilder_fieldelements') . "`.`fieldelement_name` = '" . $sortElement . "'")) {
+            $ret = false;
+        }
     }
 
     return $ret;