resolve compilation & codegen issues on delphi posix compilers (#68)

Author: Xor-el

HashLib/src/Crypto/Blake2BParams/HlpBlake2BParams.pas

@@ -97,7 +97,7 @@   TBlake2BTreeConfig = class sealed(TInterfacedObject, IBlake2BTreeConfig)
     procedure ValidateInnerHashSize(AInnerHashSize: Byte); inline;
     procedure ValidateMaxDepth(AMaxDepth: Byte); inline;
     procedure ValidateNodeDepth(ANodeDepth: Byte); inline;
-    procedure ValidateNodeOffset(ANodeOffset: UInt64); inline;
+    procedure ValidateNodeOffset(ANodeOffset: UInt64);
 
     function GetFanOut: Byte; inline;
     procedure SetFanOut(AValue: Byte); inline;
@@ -342,9 +342,10 @@ procedure TBlake2BTreeConfig.ValidateNodeDepth(ANodeDepth: Byte);
 end;
 
 procedure TBlake2BTreeConfig.ValidateNodeOffset(ANodeOffset: UInt64);
+const
+  MaxNodeOffset: UInt64 = $FFFFFFFFFFFFFFFF; // (2^64) - 1
 begin
-  // ANodeOffset > ((2^64) - 1)
-  if ANodeOffset > System.High(UInt64) then
+  if ANodeOffset > MaxNodeOffset then
   begin
     raise EArgumentInvalidHashLibException.CreateRes
       (@SInvalidNodeOffsetParameter);

HashLib/src/Include/HashLib.inc

@@ -21,6 +21,13 @@
     {$MESSAGE ERROR 'This Library requires Delphi 2010 or higher.'}
   {$IFEND}
 
+  // Silence H2586 (legacy $IFEND) on XE4+ where $ENDIF can also close $IF.
+  // The $LEGACYIFEND directive itself was introduced in XE4 (25.0), so the
+  // guard is necessary to keep Delphi 2010 / XE / XE2 / XE3 compiling.
+  {$IF CompilerVersion >= 25.0}
+    {$LEGACYIFEND ON}
+  {$IFEND}
+
   {$DEFINE DELPHI}
 
   {$DEFINITIONINFO ON} // Enable code browsing (Ctrl+Click)

HashLib/src/Utils/HlpArmHwCapProvider.pas

@@ -139,12 +139,17 @@ implementation
 
 class procedure TArmHwCapProvider.ResolveDynamicImports();
 var
-  LHandle: Pointer;
+  LHandle: NativeUInt;
 begin
   FGetAuxVal := nil;
 
+{$IFDEF FPC}
+  LHandle := NativeUInt(dlopen(nil, RTLD_NOW));
+{$ELSE}
   LHandle := dlopen(nil, RTLD_NOW);
-  if LHandle = nil then
+{$ENDIF}
+
+  if LHandle = 0 then
     Exit;
 
   try
@@ -179,12 +184,17 @@ class function TArmHwCapProvider.GetHwCap2(): UInt64;
 
 class procedure TArmHwCapProvider.ResolveDynamicImports();
 var
-  LHandle: Pointer;
+  LHandle: NativeUInt;
 begin
   FElfAuxInfo := nil;
 
+{$IFDEF FPC}
+  LHandle := NativeUInt(dlopen(nil, RTLD_NOW));
+{$ELSE}
   LHandle := dlopen(nil, RTLD_NOW);
-  if LHandle = nil then
+{$ENDIF}
+
+  if LHandle = 0 then
     Exit;
 
   try