Skip to content

Commit 4de1a05

Browse files
McKnight, Eric D.Copilot
authored andcommitted
fix(action): pull release image by bare semver tag
The Docker workflow now tags release images with the bare semver (:X.Y.Z via docker/metadata-action {{version}}), but the composite action still pulled :vX.Y.Z. That mismatch made every build resolving to >=v1.2.0 fail with a 404 on docker pull (v1.1.29 and earlier used the old v-prefixed tag, so they still worked). Pull the un-prefixed tag to match the current, documented image scheme. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 79caa1e commit 4de1a05

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

action.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,11 @@ runs:
8989
version="${tag#v}"
9090
fi
9191
92-
ref="${image}:v${version}"
92+
# Release images are tagged with the bare semver (e.g. `:1.2.0`), matching
93+
# docker/metadata-action's `type=semver,pattern={{version}}` and the scheme
94+
# documented in docs/development/versioning.md. (Older <=1.1.29 images used a
95+
# `v`-prefixed tag; those predate the current tagging workflow.)
96+
ref="${image}:${version}"
9397
echo "Using Netdocs image ${ref}"
9498
docker pull "${ref}"
9599

0 commit comments

Comments
 (0)