feature/configs#135
Merged
Merged
Conversation
Owner
Xvezda
commented
Jun 22, 2025
- Update package.json
- Misc changes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces configuration updates by modifying ESLint rules for undocumented throw statements and throws tag type, while also adjusting package.json scripts and JS project configuration.
- Updated ESLint rule files to include an explicit break after setting the callback node.
- Modified package.json to switch to pnpm for linting and building.
- Revised jsconfig.json to update include/exclude patterns.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/rules/no-undocumented-throws.js | Added a break statement to the switch block. |
| src/rules/check-throws-tag-type.js | Added a break statement similar to the previous file. |
| package.json | Updated scripts and keywords to use pnpm. |
| jsconfig.json | Added include/exclude entries for project config. |
Comments suppressed due to low confidence (4)
src/rules/no-undocumented-throws.js:603
- Verify that the addition of the break statement is consistent with similar control flow patterns in the file and does not alter the intended logic.
break;
src/rules/check-throws-tag-type.js:677
- Ensure that the newly inserted break statement aligns with the intended switch control flow and mirrors the structure used in similar cases.
break;
package.json:18
- Confirm that switching to pnpm in the prepublish script is supported by the project's tooling and update any related documentation accordingly.
"prepublish": "pnpm run lint && pnpm run build"
jsconfig.json:114
- Review the updated include patterns to ensure they accurately cover all required source files and do not unintentionally include extra files.
"include": ["src/**/*.js", "tests/**/*.js"],
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.