Add narrowing tests#139
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds new test cases to verify throwing behavior in narrowed getter/setter contexts for two ESLint rules.
- Introduces tests for
no-undocumented-throwsto ensure missing@throwstags are reported in narrowed branches. - Adds tests for
check-throws-tag-typeto validate mismatched@throwsannotations in similar scenarios.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/rules/no-undocumented-throws.test.js | New test block for getter/setter narrowing checks |
| tests/rules/check-throws-tag-type.test.js | New test block for throw type mismatch checks |
| }, | ||
| { | ||
| code: ` | ||
| class TrueGetterError extends Error {} |
There was a problem hiding this comment.
[nitpick] The error class and foo setup are duplicated in multiple test files; consider extracting shared fixtures or helper functions to reduce repetition and improve maintainability.
| }, | ||
| { | ||
| code: ` | ||
| class TrueGetterError extends Error {} |
There was a problem hiding this comment.
[nitpick] This block duplicates the same class definitions and foo function from another test; refactoring into a shared helper would make the tests easier to maintain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.