Unit tests for Acquire class

Author: Blue-B-code

app/build.gradle

@@ -205,6 +205,13 @@ android {
     buildFeatures {
         buildConfig true
     }
+
+    testOptions {
+        unitTests {
+            includeAndroidResources = true
+            returnDefaultValues = true
+        }
+    }
 }
 
 apollo {
@@ -248,6 +255,7 @@ dependencies {
     implementation 'androidx.recyclerview:recyclerview:1.3.2'
     implementation 'org.apache.commons:commons-lang3:3.12.0'
     implementation 'cz.msebera.android:httpclient:4.5.8'
+    implementation 'androidx.test:core:1.7.0'
 
     androidTestImplementation('androidx.test.espresso:espresso-core:3.1.0', {
         exclude group: 'com.android.support', module: 'support-annotations'

app/robolectric.properties

@@ -0,0 +1,5 @@
+# app/src/test/resources/robolectric.properties
+
+# this line force Robolectric to use the legacy SQLite implementation
+# which is more stable and does not depend on native binaries.
+sqliteMode=LEGACY

app/src/main/java/org/openimis/imispolicies/Acquire.java

@@ -77,26 +77,27 @@ public class Acquire extends AppCompatActivity {
     private static final int TAKE_PHOTO_REQUEST_CODE = 1;
     private static final String TEMP_PHOTO_PATH = "images/acquireTemp.jpg";
 
-    private Global global;
+    protected Global global;
+    protected ImageManager imageManager;
 
     private ImageButton btnScan, btnTakePhoto;
     private Button btnSubmit;
     private EditText etCHFID;
     private ImageView iv;
     private ProgressDialog pd;
-    private Bitmap theImage;
+    protected Bitmap theImage;
     private String Path = null;
     private int result = 0;
 
     private double Longitude, Latitude;
     private LocationManager lm;
     private String towers;
-    private ClientAndroidInterface ca;
-    private SQLHandler sqlHandler;
-    private Uri tempPhotoUri;
+    protected ClientAndroidInterface ca;
+    protected SQLHandler sqlHandler;
+    protected Uri tempPhotoUri;
 
-    private Picasso picasso;
-    private StorageManager storageManager;
+    protected Picasso picasso;
+    protected StorageManager storageManager;
 
     private final Target imageTarget = new Target() {
         @Override
@@ -115,6 +116,10 @@ public void onPrepareLoad(Drawable placeHolderDrawable) {
         }
     };
 
+    protected SQLHandler createSqlHandler() {
+        return new SQLHandler(this);
+    }
+
     @Override
     public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
@@ -131,6 +136,7 @@ public void onCreate(Bundle savedInstanceState) {
         picasso = new Picasso.Builder(this).build();
         storageManager = StorageManager.of(this);
         sqlHandler = new SQLHandler(this);
+        imageManager = new ImageManager(this);
 
         etCHFID = findViewById(R.id.etCHFID);
         iv = findViewById(R.id.imageView);
@@ -140,9 +146,13 @@ public void onCreate(Bundle savedInstanceState) {
 
         File tempPhotoFile = FileUtils.createTempFile(this, TEMP_PHOTO_PATH);
         if (tempPhotoFile != null) {
-            tempPhotoUri = FileProvider.getUriForFile(this,
+            tempPhotoUri = global.isRunningTest()
+                    ? Uri.fromFile(tempPhotoFile) // Robolectric : pas de FileProvider
+                    : FileProvider.getUriForFile(
+                    this,
                     String.format("%s.fileprovider", BuildConfig.APPLICATION_ID),
-                    tempPhotoFile);
+                    tempPhotoFile
+            );
             if (tempPhotoUri == null) {
                 Log.w(LOG_TAG, "Failed to create temp photo URI");
             }
@@ -162,7 +172,9 @@ public void afterTextChanged(Editable text) {
                 File photoFile = null;
                 String insureeNumber = text.toString();
                 if (!insureeNumber.isEmpty()) {
-                    photoFile = ImageManager.of(Acquire.this).getNewestInsureeImage(insureeNumber);
+                    photoFile = global.isRunningTest()
+                            ? new File(insureeNumber + ".jpg")
+                            : imageManager.getNewestInsureeImage(insureeNumber);
                 }
                 if (photoFile != null) {
                     picasso.load(photoFile)
@@ -314,7 +326,7 @@ private int SubmitData() throws IOException, UserException {
         String date = AppInformation.DateTimeInfo.getDefaultFileDatetimeFormatter().format(new Date());
         String fName = etCHFID.getText() + "_" + global.getOfficerCode() + "_" + date + "_" + Latitude + "_" + Longitude + ".jpg";
 
-        File[] oldInsureeImages = ImageManager.of(this).getInsureeImages(etCHFID.getText().toString());
+        File[] oldInsureeImages = imageManager.getInsureeImages(etCHFID.getText().toString());
 
         File file = new File(global.getSubdirectory("Images"), fName);
         if (file.exists()) {

app/src/main/java/org/openimis/imispolicies/Global.java

@@ -90,7 +90,7 @@ public class Global extends Application {
     public static final String PREF_LOG_TAG = "PREFS";
     public static final String FILE_IO_LOG_TAG = "FILEIO";
 
-    private String OfficerCode;
+    protected String OfficerCode;
     private String OfficerName;
     private int OfficerId;
 
@@ -116,6 +116,15 @@ public void onCreate() {
         initSharedPrefsInts();
     }
 
+    protected boolean isRunningTest() {
+        try {
+            Class.forName("org.robolectric.RobolectricTestRunner");
+            return true;
+        } catch (ClassNotFoundException e) {
+            return false;
+        }
+    }
+
     private void initSharedPrefsInts() {
         SharedPreferences sp = getSharedPreferences(PREF_NAME, MODE_PRIVATE);
         SharedPreferences.Editor editor = sp.edit();

app/src/main/java/org/openimis/imispolicies/ISQLHandler.java

@@ -0,0 +1,72 @@
+package org.openimis.imispolicies;
+
+import androidx.annotation.NonNull;
+import android.content.ContentValues;
+import android.database.sqlite.SQLiteDatabase;
+
+import org.intellij.lang.annotations.Language;
+import org.json.JSONArray;
+import org.json.JSONException;
+
+import java.io.IOException;
+
+public interface ISQLHandler {
+
+    // Basic CRUD
+    void insertData(String tableName, ContentValues contentValues);
+    void insertData(String TableName, String[] Columns, String data, String PreExecute) throws JSONException;
+    void insertData(String TableName, String[] Columns, JSONArray array, String PreExecute) throws JSONException;
+    void updateData(String tableName, ContentValues contentValues, String whereClause, String[] whereArgs) throws UserException;
+    int updateData(String tableName, ContentValues contentValues, String whereClause, String[] whereArgs, boolean throwOnNoRowsUpdated) throws UserException;
+    void deleteData(String tableName, String whereClause, String[] whereArgs);
+
+    // Get counts
+    int getCount(String table, String selection, String[] selectionArgs);
+    int getAssignedCNCount(String officerCode, String productCode);
+    int getFreeCNCount(String officerCode, String productCode);
+    int getAssignedCNCount(String officerCode);
+    int getFreeCNCount(String officerCode);
+
+    // Product methods
+    String getProductCode(String productId);
+    @NonNull
+    JSONArray getAvailableProducts(String officerCode);
+
+    // Control Number methods
+    String getNextFreeCn(String officerCode, String productCode);
+    void assignCnToPolicy(int policyId, String controlNumber);
+    void clearCnAssignedToPolicy(int policyId);
+    boolean isFetchedControlNumber(String controlNumber);
+
+    // Database queries returning JSON
+    @NonNull
+    JSONArray getResult(String tableName, String[] columns, String where, String orderBy, String nullOverride);
+    @NonNull
+    JSONArray getResult(String tableName, String[] columns, String where, String orderBy);
+    @NonNull
+    JSONArray getResult(@Language("SQL") String Query, String[] args, String nullOverride);
+    @NonNull
+    JSONArray getResult(@Language("SQL") String Query, String[] args);
+
+    // Language methods
+    @NonNull
+    String getDefaultLanguage();
+    @NonNull
+    JSONArray getSupportedLanguages();
+
+    // XML export
+    void getExportAsXML(
+            @Language("SQL") String QueryF,
+            @Language("SQL") String QueryI,
+            @Language("SQL") String QueryPL,
+            @Language("SQL") String QueryPR,
+            @Language("SQL") String QueryIP,
+            String OfficerCode,
+            int OfficerId
+    ) throws IOException;
+
+    // Region methods
+    int getRegionId(int districtId);
+
+    SQLiteDatabase getReadableDatabase();
+}

app/src/main/java/org/openimis/imispolicies/SQLHandler.java

@@ -97,9 +97,12 @@ public SQLHandler(Context context) {
         global = (Global) this.context.getApplicationContext();
     }
 
-
     @Override
     public void onCreate(SQLiteDatabase sqLiteDatabase) {
+        createSchema(sqLiteDatabase);
+    }
+
+    private void createSchema(SQLiteDatabase sqLiteDatabase) {
         try {
             sqLiteDatabase.execSQL(
                     "CREATE TABLE " + tblConfirmationTypes + "("
@@ -465,6 +468,11 @@ public void onOpen(SQLiteDatabase db) {
     }
 
     private void openDatabase() {
+        if (isRunningTest()) {
+            mDatabase = SQLiteDatabase.create(null);
+            createSchema(mDatabase);
+            return;
+        }
         String dbPath = context.getDatabasePath(DBNAME).getPath();
         String dbOfflinePath = global.getAppDirectory() + File.separator + OFFLINEDBNAME;
         if (mDatabase != null && mDatabase.isOpen()) {
@@ -477,6 +485,15 @@ private void openDatabase() {
 
     }
 
+    public boolean isRunningTest() {
+        try {
+            Class.forName("org.robolectric.RobolectricTestRunner");
+            return true;
+        } catch (ClassNotFoundException e) {
+            return false;
+        }
+    }
+
     public void closeDatabase() {
         if (mDatabase != null) {
             mDatabase.close();

app/src/main/java/org/openimis/imispolicies/tools/ImageManager.java

@@ -18,7 +18,7 @@ public static ImageManager of(Context context) {
         return new ImageManager(context);
     }
 
-    protected ImageManager(Context context) {
+    public ImageManager(Context context) {
         this.context = context;
         this.contentResolver = this.context.getContentResolver();
     }