-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/#21 travel follow shop info #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ce3d906
fix: #21 - ๋คํธ์ํฌ ์๋ฌ ๋ก๊น
์ถ๊ฐ ๋ฐ api nullable ๋ฏธ๋ฐ์ ์์
KimNahun 0b66922
fix: #21 - planB response ์๋ต api์ ๋ง๊ฒ ์์
KimNahun 4d4d41a
del: #21 - ์ฌ์ฉํ์ง ์๊ฒ ๊ธฐํ ๋ณ๊ฒฝ๋ budgetview ์ญ์ (1์ผ ๊ธฐ์ค ์์ฐ)
KimNahun f56b991
feat: #21 - ๊ธธ์ฐพ๊ธฐ ๋ฒํผ์ ๋๋ ์ ์ ์ธ๋ถ ๋ธ๋ผ์ฐ์ ๋ก ์ด๋๋๋๋ก ๊ตฌํ
KimNahun 010eec2
feat: #21 - placeDetail RIB ์ถ๊ฐ ๋ฐ chevronbutton๋๋ฅผ ์ ํด๋น ํ์ด์ง ์ด๋ ๊ตฌํ
KimNahun 36c5e29
feat: #21 - ๊ตฌ๊ธ๋งต ๊ด๋ จ api ์ฐ๊ฒฐ ๋ฐ ๊ธฐ์กด api์๋ฌ ์๋ต์ ๋ชจ๋ ๋จ์์์ api ๋จ์๋ก ๋ฆฌํฉํ ๋ง
KimNahun 1b87b01
feat: #21 - ๊ตฌ๊ธ๋งต ๊ด๋ จ api ์ค์ Interactor์์ ํธ์ถ ๊ตฌํ
KimNahun fc7dde2
design: #21 - ๊ฐ๊ฒ ์์ธ์ ๋ณด API๋ฅผ ํ์ฉํ UI ๊ตฌํ
KimNahun b2bfa71
design: #21 - ๊ฐ๊ฒ ์์ธ์ ๋ณด ์ด๋ฏธ์ง ์ปฌ๋ ์
๋ทฐ ๊ตฌํ
KimNahun 11928c8
refactor: #21 - Domain ๋ชจ๋ธ(PlaceDetail, TravelPlace, PlacePhoto) ์ง์ ์ ๋ฌ
KimNahun e018ce9
chore: #23: ์์ ํ์ ๋ฐฉ์ ๋ณ๊ฒฝ hexcolor ์ง์ -> DSKit
KimNahun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
Projects/Domain/Sources/Model/Follow/Error/ContentCardError.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // | ||
| // ContentCardError.swift | ||
| // Domain | ||
| // | ||
| // Created by kimnahun on 2026-02-09. | ||
| // Copyright ยฉ 2026 NDGL-iOS. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| /// ์ฌํ ํ ํ๋ฆฟ ์์ธ ์กฐํ API ์๋ฌ | ||
| public enum ContentCardError: Error, Sendable { | ||
| /// ์ฌํ ํ ํ๋ฆฟ์ ์ฐพ์ ์ ์์ (TRAVEL-02-001) | ||
| case notFound(message: String) | ||
| /// ์๋ฒ ์๋ฌ (COMM-08-001) | ||
| case serverError(message: String) | ||
| /// ์ ์ ์๋ ์๋ฌ | ||
| case unknown(code: String, message: String) | ||
| } |
19 changes: 19 additions & 0 deletions
19
Projects/Domain/Sources/Model/Follow/Error/ItineraryError.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // | ||
| // ItineraryError.swift | ||
| // Domain | ||
| // | ||
| // Created by kimnahun on 2026-02-09. | ||
| // Copyright ยฉ 2026 NDGL-iOS. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| /// ์ฌํ ํ ํ๋ฆฟ ์ผ์ ์กฐํ API ์๋ฌ | ||
| public enum ItineraryError: Error, Sendable { | ||
| /// ์ฌํ ํ ํ๋ฆฟ์ ์ฐพ์ ์ ์์ (TRAVEL-02-001) | ||
| case notFound(message: String) | ||
| /// ์๋ฒ ์๋ฌ (COMM-08-001) | ||
| case serverError(message: String) | ||
| /// ์ ์ ์๋ ์๋ฌ | ||
| case unknown(code: String, message: String) | ||
| } |
19 changes: 19 additions & 0 deletions
19
Projects/Domain/Sources/Model/Follow/Error/PlaceDetailError.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // | ||
| // PlaceDetailError.swift | ||
| // Domain | ||
| // | ||
| // Created by kimnahun on 2026-02-09. | ||
| // Copyright ยฉ 2026 NDGL-iOS. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| /// ์ฅ์ ์์ธ ์กฐํ API ์๋ฌ | ||
| public enum PlaceDetailError: Error, Sendable { | ||
| /// ํ์ ์์ฒญ ํ๋ผ๋ฏธํฐ๊ฐ ์กด์ฌํ์ง ์์ (COMM-01-006) | ||
| case missingParameter(message: String) | ||
| /// ์ฅ์๋ฅผ ์ฐพ์ ์ ์์ (PLACE-02-001) | ||
| case notFound(message: String) | ||
| /// ์ ์ ์๋ ์๋ฌ | ||
| case unknown(code: String, message: String) | ||
| } | ||
21 changes: 21 additions & 0 deletions
21
Projects/Domain/Sources/Model/Follow/Error/PlacePhotosError.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // | ||
| // PlacePhotosError.swift | ||
| // Domain | ||
| // | ||
| // Created by kimnahun on 2026-02-09. | ||
| // Copyright ยฉ 2026 NDGL-iOS. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| /// ์ฅ์ ์ฌ์ง ์กฐํ API ์๋ฌ | ||
| public enum PlacePhotosError: Error, Sendable { | ||
| /// ํ์ ์์ฒญ ํ๋ผ๋ฏธํฐ๊ฐ ์กด์ฌํ์ง ์์ (COMM-01-006) | ||
| case missingParameter(message: String) | ||
| /// ์๋ฒ ์๋ฌ (COMM-08-001) | ||
| case serverError(message: String) | ||
| /// Google Maps Places API ํธ์ถ ์คํจ (GMAP_PLACE-07-001) | ||
| case googleApiError(message: String) | ||
| /// ์ ์ ์๋ ์๋ฌ | ||
| case unknown(code: String, message: String) | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // | ||
| // PlaceDetail.swift | ||
| // Domain | ||
| // | ||
| // Created by kimnahun on 2026-02-09. | ||
| // Copyright ยฉ 2026 NDGL-iOS. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| /// ์ฅ์ ์์ธ ์ ๋ณด | ||
| public struct PlaceDetail: Hashable { | ||
| public let id: String | ||
| public let name: String | ||
| public let thumbnail: String? | ||
| public let nationalPhoneNumber: String? | ||
| public let internationalPhoneNumber: String? | ||
| public let formattedAddress: String? | ||
| public let location: PlaceLocation | ||
| public let userRatingCount: Int? | ||
| public let rating: Double? | ||
| public let regularOpeningHours: [String]? | ||
| public let googleMapsUri: String? | ||
| public let websiteUri: String? | ||
|
|
||
| public init( | ||
| id: String, | ||
| name: String, | ||
| thumbnail: String? = nil, | ||
| nationalPhoneNumber: String? = nil, | ||
| internationalPhoneNumber: String? = nil, | ||
| formattedAddress: String? = nil, | ||
| location: PlaceLocation, | ||
| userRatingCount: Int? = nil, | ||
| rating: Double? = nil, | ||
| regularOpeningHours: [String]? = nil, | ||
| googleMapsUri: String? = nil, | ||
| websiteUri: String? = nil | ||
| ) { | ||
| self.id = id | ||
| self.name = name | ||
| self.thumbnail = thumbnail | ||
| self.nationalPhoneNumber = nationalPhoneNumber | ||
| self.internationalPhoneNumber = internationalPhoneNumber | ||
| self.formattedAddress = formattedAddress | ||
| self.location = location | ||
| self.userRatingCount = userRatingCount | ||
| self.rating = rating | ||
| self.regularOpeningHours = regularOpeningHours | ||
| self.googleMapsUri = googleMapsUri | ||
| self.websiteUri = websiteUri | ||
| } | ||
| } | ||
|
|
||
| /// ์ฅ์ ์์น ์ ๋ณด | ||
| public struct PlaceLocation: Hashable { | ||
| public let latitude: Double | ||
| public let longitude: Double | ||
|
|
||
| public init(latitude: Double, longitude: Double) { | ||
| self.latitude = latitude | ||
| self.longitude = longitude | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // | ||
| // PlacePhoto.swift | ||
| // Domain | ||
| // | ||
| // Created by kimnahun on 2026-02-09. | ||
| // Copyright ยฉ 2026 NDGL-iOS. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| /// ์ฅ์ ์ฌ์ง ์ ๋ณด | ||
| public struct PlacePhoto: Hashable { | ||
| public let photoUri: String | ||
| public let widthPx: Int | ||
| public let heightPx: Int | ||
|
|
||
| public init(photoUri: String, widthPx: Int, heightPx: Int) { | ||
| self.photoUri = photoUri | ||
| self.widthPx = widthPx | ||
| self.heightPx = heightPx | ||
| } | ||
| } |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐งฉ Analysis chain
๐ Script executed:
rg -n 'serverError' --type=swift -C2Repository: YAPP-Github/27th-App-Team-1-iOS
Length of output: 6052
๐ Script executed:
Repository: YAPP-Github/27th-App-Team-1-iOS
Length of output: 431
๐ Script executed:
Repository: YAPP-Github/27th-App-Team-1-iOS
Length of output: 243
๐ Script executed:
fd -e swift -path "*PlaceDetailError*"Repository: YAPP-Github/27th-App-Team-1-iOS
Length of output: 243
๐ Script executed:
cat -n "Projects/Domain/Sources/Model/Follow/Error/PlacePhotosError.swift"Repository: YAPP-Github/27th-App-Team-1-iOS
Length of output: 764
๐ Script executed:
Repository: YAPP-Github/27th-App-Team-1-iOS
Length of output: 225
๐ Script executed:
Repository: YAPP-Github/27th-App-Team-1-iOS
Length of output: 431
๐ Script executed:
cat -n "Projects/Modules/Networks/Sources/ErrorMapping/Follow/PlaceDetailError+Mapping.swift"Repository: YAPP-Github/27th-App-Team-1-iOS
Length of output: 806
๐ Script executed:
Repository: YAPP-Github/27th-App-Team-1-iOS
Length of output: 1231
serverError์ผ์ด์ค ๋๋ฝ - ์ถ๊ฐ ํ์PlaceDetailError์๋PlacePhotosError,HomeError,ItineraryError,ContentCardError๋ฑ ํ๋ก์ ํธ ๋ด ๋ค๋ฅธ ์๋ฌ ํ์ ๋ค์ฒ๋ผ ์๋ฒ ์๋ฌ(COMM-08-001) ์ผ์ด์ค๊ฐ ์์ต๋๋ค. ๋ชจ๋ API ์๋ํฌ์ธํธ์์ ๋ฐ์ํ ์ ์๋ ํ์ค ์๋ฒ ์๋ฌ ์ฝ๋์ด๋ฏ๋ก, ์ผ๊ด์ฑ ์๋ ์๋ฌ ์ฒ๋ฆฌ๋ฅผ ์ํดserverError(message: String)์ผ์ด์ค๋ฅผ ์ถ๊ฐํ๊ณ ๋งคํ ํ์ผ์ ํจ๊ป ์์ ํ์ธ์.๐ค Prompt for AI Agents