Skip to content

Commit 556bc51

Browse files
committed
[fix] #91 KakaoAuthHelper.kt object로 변경
1 parent 90f7f1b commit 556bc51

3 files changed

Lines changed: 7 additions & 14 deletions

File tree

core/common/src/main/java/com/neki/android/core/common/kakao/KakaoAuthHelper.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@ package com.neki.android.core.common.kakao
33
import android.content.Context
44
import com.kakao.sdk.user.UserApiClient
55

6-
class KakaoAuthHelper(
7-
private val context: Context,
8-
) {
6+
object KakaoAuthHelper {
97
fun login(
8+
context: Context,
109
onSuccess: (String) -> Unit,
1110
onFailure: (String) -> Unit,
1211
) {

feature/auth/impl/src/main/kotlin/com/neki/android/feature/auth/impl/login/LoginScreen.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import android.widget.Toast
44
import androidx.compose.foundation.layout.Box
55
import androidx.compose.runtime.Composable
66
import androidx.compose.runtime.getValue
7-
import androidx.compose.runtime.remember
87
import androidx.compose.ui.Alignment
98
import androidx.compose.ui.Modifier
109
import androidx.compose.ui.platform.LocalContext
@@ -24,14 +23,13 @@ internal fun LoginRoute(
2423
navigateToTerm: () -> Unit,
2524
) {
2625
val context = LocalContext.current
27-
val uiState by viewModel.store.uiState.collectAsStateWithLifecycle()
28-
val kakaoAuthHelper = remember { KakaoAuthHelper(context) }
2926

3027
viewModel.store.sideEffects.collectWithLifecycle { sideEffect ->
3128
when (sideEffect) {
3229
LoginSideEffect.NavigateToTerm -> navigateToTerm()
3330
LoginSideEffect.NavigateToKakaoRedirectingUri -> {
34-
kakaoAuthHelper.login(
31+
KakaoAuthHelper.login(
32+
context = context,
3533
onSuccess = { idToken ->
3634
Timber.d("로그인 성공 $idToken")
3735
viewModel.store.onIntent(LoginIntent.SuccessLogin(idToken))

feature/mypage/impl/src/main/java/com/neki/android/feature/mypage/impl/profile/ProfileSettingScreen.kt

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,12 @@ import androidx.compose.foundation.layout.Column
44
import androidx.compose.foundation.layout.fillMaxSize
55
import androidx.compose.runtime.Composable
66
import androidx.compose.runtime.getValue
7-
import androidx.compose.runtime.remember
87
import androidx.compose.ui.Alignment
98
import androidx.compose.ui.Modifier
10-
import androidx.compose.ui.platform.LocalContext
119
import androidx.compose.ui.window.DialogProperties
1210
import androidx.hilt.lifecycle.viewmodel.compose.hiltViewModel
1311
import androidx.lifecycle.compose.collectAsStateWithLifecycle
12+
import com.neki.android.core.common.kakao.KakaoAuthHelper
1413
import com.neki.android.core.designsystem.ComponentPreview
1514
import com.neki.android.core.designsystem.dialog.DoubleButtonAlertDialog
1615
import com.neki.android.core.designsystem.ui.theme.NekiTheme
@@ -24,7 +23,6 @@ import com.neki.android.feature.mypage.impl.main.MyPageState
2423
import com.neki.android.feature.mypage.impl.main.MyPageViewModel
2524
import com.neki.android.feature.mypage.impl.profile.component.ProfileSettingTopBar
2625
import com.neki.android.feature.mypage.impl.profile.component.SettingProfileImage
27-
import com.neki.android.core.common.kakao.KakaoAuthHelper
2826
import timber.log.Timber
2927

3028
@Composable
@@ -34,23 +32,21 @@ internal fun ProfileSettingRoute(
3432
navigateToEditProfile: () -> Unit,
3533
navigateToLogin: () -> Unit,
3634
) {
37-
val context = LocalContext.current
3835
val uiState by viewModel.store.uiState.collectAsStateWithLifecycle()
39-
val kakaoAuthHelper = remember { KakaoAuthHelper(context) }
4036

4137
viewModel.store.sideEffects.collectWithLifecycle { sideEffect ->
4238
when (sideEffect) {
4339
MyPageEffect.NavigateBack -> navigateBack()
4440
MyPageEffect.NavigateToEditProfile -> navigateToEditProfile()
4541
MyPageEffect.NavigateToLogin -> navigateToLogin()
4642
MyPageEffect.LogoutWithKakao -> {
47-
kakaoAuthHelper.logout(
43+
KakaoAuthHelper.logout(
4844
onSuccess = { navigateToLogin() },
4945
onFailure = { Timber.e(it) },
5046
)
5147
}
5248
MyPageEffect.UnlinkWithKakao -> {
53-
kakaoAuthHelper.unlink(
49+
KakaoAuthHelper.unlink(
5450
onSuccess = { navigateToLogin() },
5551
onFailure = { Timber.e(it) },
5652
)

0 commit comments

Comments
 (0)