Merge pull request #106 from YAPP-Github/feat/#105-api-exception

[refactor] #105 API Exception 클래스 구조 개선

Author: ikseong00

core/common/src/main/java/com/neki/android/core/common/exception/ApiErrorCode.kt

@@ -0,0 +1,5 @@
+package com.neki.android.core.common.exception
+
+object ApiErrorCode {
+    const val NO_MORE_RANDOM_POSE = 400
+}

core/common/src/main/java/com/neki/android/core/common/exception/ApiException.kt

@@ -1,11 +1,13 @@
 package com.neki.android.core.common.exception
 
-class ServerApiException(
-    val code: Int,
-    message: String,
-) : Throwable(message)
+open class NekiApiException(
+    open val code: Int,
+    override val message: String,
+    override val cause: Throwable?,
+) : Exception(message, cause)
 
-class ClientApiException(
-    val code: Int,
-    message: String,
-) : Throwable(message)
+class NoMorePoseException(
+    override val code: Int,
+    override val message: String,
+    override val cause: Throwable?,
+) : NekiApiException(code, message, cause)

core/data-api/src/main/java/com/neki/android/core/dataapi/repository/PoseRepository.kt

@@ -6,8 +6,6 @@ import com.neki.android.core.model.Pose
 import com.neki.android.core.model.SortOrder
 import kotlinx.coroutines.flow.Flow
 
-const val NO_MORE_RANDOM_POSE = 400
-
 interface PoseRepository {
 
     fun getPosesFlow(

core/data/src/main/java/com/neki/android/core/data/repository/impl/PoseRepositoryImpl.kt

@@ -3,12 +3,12 @@ package com.neki.android.core.data.repository.impl
 import androidx.paging.Pager
 import androidx.paging.PagingConfig
 import androidx.paging.PagingData
-import com.neki.android.core.common.exception.ClientApiException
+import com.neki.android.core.common.exception.ApiErrorCode.NO_MORE_RANDOM_POSE
+import com.neki.android.core.common.exception.NoMorePoseException
 import com.neki.android.core.data.paging.PosePagingSource
 import com.neki.android.core.data.paging.ScrapPosePagingSource
 import com.neki.android.core.data.remote.api.PoseService
 import com.neki.android.core.data.util.runSuspendCatching
-import com.neki.android.core.dataapi.repository.NO_MORE_RANDOM_POSE
 import com.neki.android.core.dataapi.repository.PoseRepository
 import com.neki.android.core.model.PeopleCount
 import com.neki.android.core.model.Pose
@@ -81,8 +81,9 @@ class PoseRepositoryImpl @Inject constructor(
             ).data.toModel()
         } catch (e: ClientRequestException) {
             if (e.response.status.value == NO_MORE_RANDOM_POSE)
-                throw ClientApiException(NO_MORE_RANDOM_POSE, e.message)
-            else throw e
+                throw NoMorePoseException(NO_MORE_RANDOM_POSE, e.message, e)
+            else
+                throw e
         }
     }
 

feature/pose/impl/src/main/java/com/neki/android/feature/pose/impl/random/RandomPoseViewModel.kt

@@ -3,8 +3,8 @@ package com.neki.android.feature.pose.impl.random
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.viewModelScope
 import com.neki.android.core.common.coroutine.di.ApplicationScope
-import com.neki.android.core.common.exception.ClientApiException
-import com.neki.android.core.dataapi.repository.NO_MORE_RANDOM_POSE
+import com.neki.android.core.common.exception.ApiErrorCode.NO_MORE_RANDOM_POSE
+import com.neki.android.core.common.exception.NoMorePoseException
 import com.neki.android.core.dataapi.repository.PoseRepository
 import com.neki.android.core.dataapi.repository.UserRepository
 import com.neki.android.core.model.PeopleCount
@@ -168,7 +168,7 @@ internal class RandomPoseViewModel @AssistedInject constructor(
                         )
                     }
                 }.onFailure { error ->
-                    if (error is ClientApiException && error.code == NO_MORE_RANDOM_POSE) {
+                    if (error is NoMorePoseException && error.code == NO_MORE_RANDOM_POSE) {
                         reduce { copy(hasNewPose = false) }
                         postSideEffect(RandomPoseEffect.ShowToast("모든 포즈를 불러왔어요"))
                     } else Timber.e(error)