Skip to content

[fix] #165,#193 만료 QR 및 미지원 QR 중복 로깅 버그 수정#198

Merged
ikseong00 merged 2 commits into
developfrom
fix/#165,#193-qr-scan
Apr 20, 2026
Merged

[fix] #165,#193 만료 QR 및 미지원 QR 중복 로깅 버그 수정#198
ikseong00 merged 2 commits into
developfrom
fix/#165,#193-qr-scan

Conversation

@ikseong00
Copy link
Copy Markdown
Contributor

🔗 관련 이슈

📙 작업 설명

  • 미지원 브랜드 QR 스캔 시 Discord 로깅이 5~6건 중복 전송되던 문제 해결 (ML Kit BarcodeScanner 연속 콜백 원인)
    • loggedUnsupportedUrls Set 기반 dedupe 적용 — 같은 URL은 세션 내 1회만 로깅
  • 만료/404 QR 스캔 시 흰 화면 채로 멈추던 문제 해결
    • PhotoWebViewClientonReceivedError / onReceivedHttpError 추가 (main frame 한정)
    • 신규 QRScanIntent.WebViewError 처리: 토스트 "만료되었거나 유효하지 않은 QR코드입니다." 안내 + 스캐너 화면 복귀

🧪 테스트 내역 (선택)

  • 미지원 브랜드 QR 연속 스캔 시 Discord 로깅 1건만 전송
  • 다른 미지원 URL 스캔 시에는 추가 1건 로깅
  • 만료/404 URL QR 스캔 시 토스트 노출 + 스캐너 복귀
  • 정상 지원 브랜드 QR 회귀 없음

📸 스크린샷 또는 시연 영상 (선택)

💬 추가 설명 or 리뷰 포인트 (선택)

  • WebView HTTP 에러는 서브리소스(이미지/광고) 404에도 발화하므로 request.isForMainFrame == true 가드 필수

@ikseong00 ikseong00 added the fix label Apr 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 19, 2026

Warning

Rate limit exceeded

@ikseong00 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 41 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 12 minutes and 41 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cf197dbc-5c29-4e04-ab22-00ca728b127d

📥 Commits

Reviewing files that changed from the base of the PR and between 7079540 and 2e6987d.

📒 Files selected for processing (5)
  • feature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/qrscan/QRScanContract.kt
  • feature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/qrscan/QRScanScreen.kt
  • feature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/qrscan/QRScanViewModel.kt
  • feature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/qrscan/component/PhotoWebViewContent.kt
  • feature/photo-upload/impl/src/main/java/com/neki/android/feature/photo_upload/impl/qrscan/util/PhotoWebViewClient.kt
✨ Finishing Touches
🧪 Generate unit tests (beta)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@Ojongseok Ojongseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 없어보입니다-! 👍

@ikseong00 ikseong00 merged commit a361451 into develop Apr 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] 미지원 QR 스캔 시 여러번 로깅되는 현상 수정 [fix] 만료된 QR 핸들링

2 participants