-
Notifications
You must be signed in to change notification settings - Fork 0
[refactor] #51 네컷지도 기능 및 UI 고도화 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
39f8a13
[chore] #51 드래그 관련 상수 네이밍 변경
Ojongseok 99149f5
[design] #51 BottomNavigationBar 디자인 변경사항 반영
Ojongseok 0c2d70e
[refactor] #51 AnchoredDraggablePanel 드래그 레벨별 높이 조절 방식 로직 변경
Ojongseok a1b3208
[feat] #51 '현 위치에서 탐색' 컴포넌트 정의
Ojongseok 60e8997
[feat] #51 지도 버튼 컴포넌트 .noRippleClickableSingle로 변경
Ojongseok bf53d05
[feat] #51 하단 패널 DragLevel.THIRD 상태 높이 화면 90%로 변경
Ojongseok d1240e8
[chore] #51 불필요한 패널 높이 변수 제거
Ojongseok d2fd2c9
[feat] #51 DragLevel First, Second 상태의 '현 위치에서 탐색' 버튼 노출
Ojongseok 01c3df2
[feat] #51 NaverMap isZoomControlEnabled 속성 false로 설정
Ojongseok 3ba09fa
[feat] #51 '현 위치에서 탐색' 버튼 UI 로직 구성
Ojongseok 8c906cc
[feat] #51 현위치에 따른 길찾기 앱 이동 로직 수정
Ojongseok 8c5f0d5
[feat] #51 core:data-api dataStore 의존성 추가
Ojongseok 38a0713
[feat] #51 feat:map:impl activity-compose 의존성 추가
Ojongseok 3cbe6c9
[feat] #51 Boolean 타입을 저장할 DataStoreRepository 인터페이스 작성
Ojongseok 6f5c983
[feat] #51 DataStore Key 정의 경로 변경
Ojongseok 39d7e54
[feat] #51 accessToken, refreshToken 조회 로직 nonNull 타입으로 변경
Ojongseok c601a61
[feat] #51 네컷지도 위치권한 확인 로직 추가
Ojongseok c815bc7
[feat] #51 권한 관련 공통 로직을 작성하는 PermissionManager.kt 정의
Ojongseok 329983b
[feat] #51 위치 권한 확인 시점 추가(네컷지도 화면 진입 시, 길찾기 버튼 선택 시)
Ojongseok 00b046a
[build] #51 detekt 룰 적용
Ojongseok 7baf582
[fix] #51 clearTokens()가 accessToken과 refreshToken만 지우도록 수정
Ojongseok 33e368f
[fix] #51 MapContract 내 현위치 nullable하도록 수정
Ojongseok 593a1b8
[fix] #51 일부 Brand~ -> PhotoBooth 네이밍 변경 및 CloseButton 분리
Ojongseok eb2980e
[build] #51 detekt 룰 적용
Ojongseok 9d6cd4b
[fix] #51 권한 관련 매니저 클래스 권한 단위로 분리
Ojongseok f6ff2f6
[fix] #51 드래그 관련 높이 상수 네이밍 변경
Ojongseok f51fa03
[fix] #51 MapRefreshChip.kt 수평 패딩 수정
Ojongseok 34a6471
[fix] #51 가까운 네컷 사진 브랜드 더미데이터 조회 로직 수정
Ojongseok 6a1ce94
[fix] #51 @Qualifier 활용해 Token / Auth DataStore 인스턴스 분리
Ojongseok 0739538
[fix] #51 현위치 조회하지 못한 경우 토스트메시지 NekiToast로 변경
Ojongseok d409dd7
[fix] #51 위치 권한 여부에 따른 Intent, Effect 처리 로직 개선
Ojongseok dbf64bb
[fix] #51 위치권한 여부 체크 프로세스 변경
Ojongseok d62e281
[fix] #51 패널 관련 상수 네이밍 변경
Ojongseok 42ea247
[fix] #51 토스트메시지 remember 변수 정의 제거
Ojongseok 7647462
[fix] #51 위치 권한 이전 shouldShowRationale 확인 로직 추가
Ojongseok 68da56c
[build] #51 detekt 룰 적용
Ojongseok 10b6dca
[design] #51 pinShadow() 확장함수 추가 및 PhotoBoothMarker shadow 효과 적용
Ojongseok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
...common/src/main/java/com/neki/android/core/common/permission/LocationPermissionManager.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package com.neki.android.core.common.permission | ||
|
|
||
| import android.Manifest | ||
| import android.app.Activity | ||
| import android.content.Context | ||
| import androidx.core.content.ContextCompat | ||
| import androidx.core.content.PermissionChecker | ||
|
|
||
| object LocationPermissionManager { | ||
| val LOCATION_PERMISSIONS = arrayOf( | ||
| Manifest.permission.ACCESS_FINE_LOCATION, | ||
| Manifest.permission.ACCESS_COARSE_LOCATION, | ||
| ) | ||
|
|
||
| fun hasLocationPermission(context: Context): Boolean { | ||
| return ContextCompat.checkSelfPermission( | ||
| context, | ||
| Manifest.permission.ACCESS_FINE_LOCATION, | ||
| ) == PermissionChecker.PERMISSION_GRANTED || | ||
| ContextCompat.checkSelfPermission( | ||
| context, | ||
| Manifest.permission.ACCESS_COARSE_LOCATION, | ||
| ) == PermissionChecker.PERMISSION_GRANTED | ||
| } | ||
|
|
||
| fun shouldShowLocationRationale(activity: Activity): Boolean { | ||
| return activity.shouldShowRequestPermissionRationale(Manifest.permission.ACCESS_FINE_LOCATION) | ||
| } | ||
| } |
13 changes: 13 additions & 0 deletions
13
core/common/src/main/java/com/neki/android/core/common/permission/PermissionUtils.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package com.neki.android.core.common.permission | ||
|
|
||
| import android.content.Context | ||
| import android.content.Intent | ||
| import android.net.Uri | ||
| import android.provider.Settings | ||
|
|
||
| fun navigateToAppSettings(context: Context) { | ||
| val intent = Intent(Settings.ACTION_APPLICATION_DETAILS_SETTINGS).apply { | ||
| data = Uri.fromParts("package", context.packageName, null) | ||
| } | ||
| context.startActivity(intent) | ||
|
Ojongseok marked this conversation as resolved.
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
core/data-api/src/main/java/com/neki/android/core/dataapi/datastore/DataStoreKey.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package com.neki.android.core.dataapi.datastore | ||
|
|
||
| import androidx.datastore.preferences.core.booleanPreferencesKey | ||
| import androidx.datastore.preferences.core.stringPreferencesKey | ||
|
|
||
| object DataStoreKey { | ||
|
ikseong00 marked this conversation as resolved.
|
||
| val ACCESS_TOKEN = stringPreferencesKey("access_token") | ||
| val REFRESH_TOKEN = stringPreferencesKey("refresh_token") | ||
|
|
||
| val IS_FIRST_LOCATION_PERMISSION = booleanPreferencesKey("is_first_location_permission") | ||
|
Ojongseok marked this conversation as resolved.
|
||
| } | ||
12 changes: 3 additions & 9 deletions
12
core/data-api/src/main/java/com/neki/android/core/dataapi/repository/DataStoreRepository.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,9 @@ | ||
| package com.neki.android.core.dataapi.repository | ||
|
|
||
| import androidx.datastore.preferences.core.Preferences | ||
| import kotlinx.coroutines.flow.Flow | ||
|
|
||
| interface DataStoreRepository { | ||
| suspend fun saveJwtTokens( | ||
| accessToken: String, | ||
| refreshToken: String, | ||
| ) | ||
|
|
||
| fun isSavedJwtTokens(): Flow<Boolean> | ||
| fun getAccessToken(): Flow<String?> | ||
| fun getRefreshToken(): Flow<String?> | ||
| suspend fun clearTokens() | ||
| suspend fun setBoolean(key: Preferences.Key<Boolean>, value: Boolean) | ||
| fun getBoolean(key: Preferences.Key<Boolean>): Flow<Boolean> | ||
| } |
14 changes: 14 additions & 0 deletions
14
core/data-api/src/main/java/com/neki/android/core/dataapi/repository/TokenRepository.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package com.neki.android.core.dataapi.repository | ||
|
|
||
| import kotlinx.coroutines.flow.Flow | ||
|
|
||
| interface TokenRepository { | ||
| suspend fun saveTokens( | ||
| accessToken: String, | ||
| refreshToken: String, | ||
| ) | ||
| fun isSavedTokens(): Flow<Boolean> | ||
| fun getAccessToken(): Flow<String> | ||
| fun getRefreshToken(): Flow<String> | ||
| suspend fun clearTokens() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
core/data/src/main/java/com/neki/android/core/data/local/di/DataStoreQualifier.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package com.neki.android.core.data.local.di | ||
|
|
||
| import javax.inject.Qualifier | ||
|
|
||
| @Qualifier | ||
| @Retention(AnnotationRetention.BINARY) | ||
| annotation class AuthDataStore | ||
|
|
||
| @Qualifier | ||
| @Retention(AnnotationRetention.BINARY) | ||
| annotation class TokenDataStore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.