-
Notifications
You must be signed in to change notification settings - Fork 0
[fix] #78 아카이브 업로드 QA 수정 #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
4d7b4f7
[refactor] #78: 아카이브 앨범 LazyColumn의 verticalArrangement 제거
ikseong00 c3120b5
[chore] #78: 즐겨찾는 사진 앨범명 즐겨찾기로 수정
ikseong00 938970b
[feat] #78: 로딩 애니메이션 Lottie 종속성 및 리소스 추가
ikseong00 2248019
[feat] #78: 로딩 인디케이터 Lottie 애니메이션으로 변경
ikseong00 28b14ca
[feat] #78: 네키 타이포 로고 아이콘 추가
ikseong00 1ec67f4
[refactor] #78: 앨범 커버 디자인 개선 및 블러 효과(Haze) 적용
ikseong00 b55efad
[feat] #78: 공통 `ToolTipPopup` 컴포저블 추가 및 적용
ikseong00 cb88209
[feat] #78: 포토 그리드 아이템 오버레이 컴포저블 추가 및 적용
ikseong00 0210ea2
[feat] #78: Empty 뷰 수정사항 적용
ikseong00 019bfef
[refactor] #78: 포토 그리드 배경에 alpha 0.04f의 검은색 배경 레이어 추가
ikseong00 17a0e2e
[fix] #78: 이미지 업로드 시 EXIF 회전 방향 보정 적용
ikseong00 94e557e
[refactor] #78: backgroundHazeBlur KDoc 주석 업데이트 및 미사용 파라미터 제거
ikseong00 f18f6d7
[feat] #78: ToolTipPopup onDismissRequest 콜백 추가 및 팝업 dismiss 분리
ikseong00 1eaf057
[fix] #78: PhotoComponent cornerRadius 12dp에서 8dp로 수정
ikseong00 ce04f30
[refactor] #78: SelectablePhotoItem 선택 시 검은 배경 오버레이 제거 및 미사용 import 정리
ikseong00 aa10101
[refactor] #78: AlbumDetailContent 접근제어자 internal로 변경
ikseong00 d71f0d1
[refactor] #78: 아카이브 전체보기 버튼 터치 영역 수정
ikseong00 b63b96b
[refactor] #78: BuildConfig 필드명 오타 수정
ikseong00 d1833d2
[refactor] #78: `AlbumDetailTopBar`의 클릭 이벤트 핸들러에 기본값 추가
ikseong00 1fcc6c4
[fix] #78: `SelectablePhotoItem` 컴포저블 파일명 오타 수정 및 radius 값 변경
ikseong00 9565c8e
[refactor] #78: 앨범 목록 리스트 Arrangement.spacedBy(20.dp) 속성 제거
ikseong00 b233af2
[refactor] #78: ItemOverlay에서 photoGridBackground Modifier 제거
ikseong00 7545aa4
[chore] #78: detekt 린트 수정
ikseong00 e84480e
Merge branch 'develop' into fix/#78-archive-upload-qa
ikseong00 f9f49af
[fix] #78: 랜덤 포즈 이미지 흐림 효과 및 그라데이션 배경 추가
ikseong00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
core/designsystem/src/main/java/com/neki/android/core/designsystem/logo/NekiTypoLogo.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| package com.neki.android.core.designsystem.logo | ||
|
|
||
| import androidx.compose.material3.Icon | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.graphics.Color | ||
| import androidx.compose.ui.graphics.vector.ImageVector | ||
| import androidx.compose.ui.res.vectorResource | ||
| import androidx.compose.ui.tooling.preview.Preview | ||
| import com.neki.android.core.designsystem.ComponentPreview | ||
| import com.neki.android.core.designsystem.R | ||
| import com.neki.android.core.designsystem.ui.theme.NekiTheme | ||
|
|
||
| @Composable | ||
| private fun NekiTypoLogo( | ||
| color: Color, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| Icon( | ||
| imageVector = ImageVector.vectorResource(R.drawable.icon_neki_logo_typo), | ||
| contentDescription = null, | ||
| tint = color, | ||
| modifier = modifier, | ||
| ) | ||
| } | ||
|
|
||
| @Composable | ||
| fun PrimaryNekiTypoLogo( | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| NekiTypoLogo( | ||
| color = NekiTheme.colorScheme.primary400, | ||
| modifier = modifier, | ||
| ) | ||
| } | ||
|
|
||
| @Composable | ||
| fun GrayNekiTypoLogo( | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| NekiTypoLogo( | ||
| color = NekiTheme.colorScheme.gray900, | ||
| modifier = modifier, | ||
| ) | ||
| } | ||
|
|
||
| @Composable | ||
| fun WhiteNekiTypoLogo( | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| NekiTypoLogo( | ||
| color = NekiTheme.colorScheme.white, | ||
| modifier = modifier, | ||
| ) | ||
| } | ||
|
|
||
| @ComponentPreview | ||
| @Composable | ||
| private fun PrimaryNekiTypoLogoPreview() { | ||
| NekiTheme { | ||
| PrimaryNekiTypoLogo() | ||
| } | ||
| } | ||
|
|
||
| @ComponentPreview | ||
| @Composable | ||
| private fun GrayNekiTypoLogoPreview() { | ||
| NekiTheme { | ||
| GrayNekiTypoLogo() | ||
| } | ||
| } | ||
|
|
||
| @Preview | ||
| @Composable | ||
| private fun WhiteNekiTypoLogoPreview() { | ||
| NekiTheme { | ||
| WhiteNekiTypoLogo() | ||
| } | ||
| } | ||
|
ikseong00 marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
core/designsystem/src/main/java/com/neki/android/core/designsystem/popup/ToolTipPopup.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| package com.neki.android.core.designsystem.popup | ||
|
|
||
| import androidx.compose.foundation.Canvas | ||
| import androidx.compose.foundation.background | ||
| import androidx.compose.foundation.layout.Box | ||
| import androidx.compose.foundation.layout.Column | ||
| import androidx.compose.foundation.layout.IntrinsicSize | ||
| import androidx.compose.foundation.layout.fillMaxWidth | ||
| import androidx.compose.foundation.layout.padding | ||
| import androidx.compose.foundation.layout.size | ||
| import androidx.compose.foundation.layout.width | ||
| import androidx.compose.foundation.shape.RoundedCornerShape | ||
| import androidx.compose.material3.Text | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.Alignment | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.graphics.Color | ||
| import androidx.compose.ui.graphics.Path | ||
| import androidx.compose.ui.unit.IntOffset | ||
| import androidx.compose.ui.unit.dp | ||
| import androidx.compose.ui.window.Popup | ||
| import com.neki.android.core.designsystem.ComponentPreview | ||
| import com.neki.android.core.designsystem.ui.theme.NekiTheme | ||
|
|
||
| @Composable | ||
| fun ToolTipPopup( | ||
| tooltipText: String, | ||
| color: Color, | ||
| offset: IntOffset, | ||
| alignment: Alignment, | ||
| onDismissRequest: () -> Unit, | ||
| ) { | ||
| Popup( | ||
| alignment = alignment, | ||
| offset = offset, | ||
| onDismissRequest = onDismissRequest, | ||
| ) { | ||
| ToolTipContent( | ||
| tooltipText = tooltipText, | ||
| color = color, | ||
| ) | ||
| } | ||
| } | ||
|
ikseong00 marked this conversation as resolved.
|
||
|
|
||
| @Composable | ||
| private fun ToolTipContent( | ||
| tooltipText: String, | ||
| color: Color, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| Column( | ||
| modifier = modifier.width(IntrinsicSize.Max), | ||
| ) { | ||
| // 꼬리 (오른쪽 정렬, 오른쪽에서 16dp) | ||
| Box( | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(end = 16.dp), | ||
| contentAlignment = Alignment.CenterEnd, | ||
| ) { | ||
| Canvas( | ||
| modifier = Modifier.size(width = 10.dp, height = 8.dp), | ||
| ) { | ||
| val cornerRadius = 1.dp.toPx() | ||
| val path = Path().apply { | ||
| // 왼쪽 하단에서 시작 | ||
| moveTo(0f, size.height) | ||
| // 왼쪽 하단 -> 꼭대기 (둥근 모서리) | ||
| lineTo( | ||
| size.width / 2 - cornerRadius, | ||
| cornerRadius, | ||
| ) | ||
| quadraticTo( | ||
| size.width / 2, | ||
| 0f, | ||
| size.width / 2 + cornerRadius, | ||
| cornerRadius, | ||
| ) | ||
| // 꼭대기 -> 오른쪽 하단 | ||
| lineTo(size.width, size.height) | ||
| close() | ||
| } | ||
| drawPath(path, color) | ||
| } | ||
| } | ||
|
|
||
| // 몸통 | ||
| Box( | ||
| modifier = Modifier | ||
| .background( | ||
| color = color, | ||
| shape = RoundedCornerShape(8.dp), | ||
| ) | ||
| .padding(horizontal = 12.dp, vertical = 8.dp), | ||
| ) { | ||
| Text( | ||
| text = tooltipText, | ||
| style = NekiTheme.typography.body14Medium, | ||
| color = NekiTheme.colorScheme.white, | ||
| ) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @ComponentPreview | ||
| @Composable | ||
| private fun ToolTipPopupPreview() { | ||
| NekiTheme { | ||
| Box(modifier = Modifier.padding(16.dp)) { | ||
| ToolTipContent( | ||
| tooltipText = "툴팁 메시지입니다", | ||
| color = NekiTheme.colorScheme.gray800, | ||
| ) | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.