Merged
Conversation
- 루틴 추천 화면 기본 간격여백 추가
Walkthrough
Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant RecommendRoutineScreen
participant LazyColumn
participant Spacer
User->>RecommendRoutineScreen: 화면 진입
RecommendRoutineScreen->>LazyColumn: 루틴 리스트 렌더링
LazyColumn->>Spacer: 마지막에 110.dp Spacer 추가
Spacer-->>User: 바텀네비 위 패딩 확보
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Assessment against linked issues
Suggested labels
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
presentation/src/main/java/com/threegap/bitnagil/presentation/recommendroutine/RecommendRoutineScreen.kt (1)
177-179: 하단 스페이서 추가로 콘텐츠 가시성 개선
LazyColumn하단에 110.dp 스페이서를 추가하여 추천 루틴 목록이 하단 네비게이션 바에 가려지지 않도록 한 것은 문제를 효과적으로 해결합니다.다만 110.dp라는 하드코딩된 값이 하단 네비게이션 바 높이가 변경될 경우 유지보수성에 영향을 줄 수 있습니다. 가능하다면 테마나 상수로 관리하는 것을 고려해보세요.
향후 개선을 위한 제안:
+// Constants.kt 또는 테마에서 +val BottomNavigationSpacing = 110.dp - item { - Spacer(modifier = Modifier.height(110.dp)) - } + item { + Spacer(modifier = Modifier.height(BottomNavigationSpacing)) + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavHost.kt(2 hunks)presentation/src/main/java/com/threegap/bitnagil/presentation/recommendroutine/RecommendRoutineScreen.kt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (1)
app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavHost.kt (1)
57-62: 하단 내비게이션 바와 콘텐츠 간의 패딩 관리 개선
contentWindowInsets를 명시적으로 0으로 설정하고innerPadding을NavHost에 적용한 것은 좋은 접근입니다. 이를 통해 시스템 윈도우 인셋을 수동으로 제어할 수 있고, 스캐폴드가 계산한 패딩(하단 네비게이션 바 공간 포함)을 정확히 적용할 수 있습니다.
l5x5l
approved these changes
Aug 7, 2025
Contributor
l5x5l
left a comment
l5x5l
left a comment
There was a problem hiding this comment.
고생 많으셨어요! compose상의 insets관련해서는 한번 조사해보겠습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ PR Content ]
추천 루틴 화면 패딩 영역관련 이슈를 해결했습니다.
Related issue
Screenshot 📸
Screen_recording_20250807_140530.mp4
Work Description
To Reviewers 📢
Summary by CodeRabbit
스타일
개선사항