refactor: 코드리뷰 반영

Author: taipaise

Projects/Presentation/Sources/Common/Component/NetworkErrorView.swift

@@ -13,7 +13,7 @@ final class NetworkErrorView: UIView {
         static let contentViewWidth: CGFloat = 204
         static let contentViewHeight: CGFloat = 215
         static let errorImageSize: CGFloat = 40
-        static let boldtitleLabelTopSpacing: CGFloat = 21
+        static let boldTitleLabelTopSpacing: CGFloat = 21
         static let boldTitleLabelHeight: CGFloat = 30
         static let mediumTitleLabelTopSpacing: CGFloat = 2
         static let mediumTitleLabelHeight: CGFloat = 24
@@ -95,7 +95,7 @@ final class NetworkErrorView: UIView {
         boldTitleLabel.snp.makeConstraints { make in
             make.top
                 .equalTo(errorImageView.snp.bottom)
-                .offset(Layout.boldtitleLabelTopSpacing)
+                .offset(Layout.boldTitleLabelTopSpacing)
 
             make.height.equalTo(Layout.boldTitleLabelHeight)
 

Projects/Presentation/Sources/Common/Protocol/BaseViewController.swift

@@ -13,13 +13,17 @@ public class BaseViewController<T: ViewModel>: UIViewController {
     let viewModel: T
     private var baseCancellables = Set<AnyCancellable>()
     private lazy var networkErrorView = NetworkErrorView()
+    private var isShowingNetworkError = false
+
 
     init(viewModel: T) {
         self.viewModel = viewModel
         super.init(nibName: nil, bundle: nil)
     }
 
     deinit {
+        guard isShowingNetworkError else { return }
+
         DispatchQueue.main.async { [weak tabBarController = self.tabBarController] in
             tabBarController?.tabBar.isHidden = false
         }
@@ -74,6 +78,8 @@ public class BaseViewController<T: ViewModel>: UIViewController {
 
     /// 네트워크 에러 뷰 를 보이거나 숨깁니다.
     private func handleNetworkErrorView(show: Bool) {
+        isShowingNetworkError = show
+
         if show {
             view.bringSubviewToFront(networkErrorView)
             networkErrorView.isHidden = false

Projects/Presentation/Sources/ResultRecommendedRoutine/ViewModel/ResultRecommendedRoutineViewModel.swift

@@ -168,7 +168,7 @@ final class ResultRecommendedRoutineViewModel: ViewModel {
                 registerRoutineResultSubject.send(false)
 
                 networkRetryHandler.handleNetworkError(error) { [weak self] in
-                    self?.fetchResultRecommendedRoutines()
+                    self?.registerRecommendedRoutine()
                 }
             }
         }

Projects/Presentation/Sources/RoutineList/ViewModel/RoutineListViewModel.swift

@@ -138,7 +138,7 @@ final class RoutineListViewModel: ViewModel {
                 deleteRoutineResultSubject.send(false)
 
                 networkRetryHandler.handleNetworkError(error) { [weak self] in
-                    self?.fetchRoutines()
+                    self?.deleteRoutine(isDeleteAllRoutines: isDeleteAllRoutines)
                 }
             }
         }